Skip to content

Conversation

@ChumpChief
Copy link
Contributor

@ChumpChief ChumpChief commented May 11, 2023

This change removes three deprecated items:

  1. "localHelp" event on IContainerRuntimeEvents (Remove IHelpMessage, IQueueMessage, RemoteHelp and deprecate localHelp event #15518 followup)
  2. PureDataObject.getFluidObjectFromDirectory (Deprecate PureDataObject.getFluidObjectFromDirectory #15530 followup)
  3. IProvideContainerRuntime (Deprecate IFluidObject Module Augmentation #8299 followup)

For the last one, I also remove the automatic registration of the container runtime in the BaseContainerRuntimeFactory's dependency container (this seems inappropriate to me anyway) and removed the property from ContainerRuntime as well. I've proactively removed usages of the property from the Loop app.

@ChumpChief ChumpChief requested review from a team and msfluid-bot as code owners May 11, 2023 19:54
@ChumpChief ChumpChief requested a review from anthony-murphy May 11, 2023 19:54
@github-actions github-actions bot added area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: runtime Runtime related issues breaking change This PR or issue would introduce a breaking change public api change Changes to a public API base: next PRs targeted against next branch labels May 11, 2023
@ChumpChief ChumpChief requested a review from tylerbutler May 11, 2023 19:54
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented May 11, 2023

@fluid-example/bundle-size-tests: -490 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 446.25 KB 445.79 KB -478 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 237.63 KB 237.6 KB -34 Bytes
loader.js 154.52 KB 154.53 KB +4 Bytes
map.js 46.66 KB 46.67 KB +2 Bytes
matrix.js 146.16 KB 146.17 KB +2 Bytes
odspDriver.js 92.25 KB 92.25 KB +6 Bytes
odspPrefetchSnapshot.js 43.64 KB 43.64 KB +4 Bytes
sharedString.js 161.47 KB 161.47 KB +2 Bytes
sharedTree2.js 276.37 KB 276.37 KB No change
Total Size 1.72 MB 1.72 MB -490 Bytes

Baseline commit: a44050a

Generated by 🚫 dangerJS against 6528d0a

@tylerbutler tylerbutler added the changeset-required PR requires a changeset label May 12, 2023
@github-actions
Copy link
Contributor

Please review this PR: @sonalideshpandemsft @tylerbutler @scottn12

@ChumpChief
Copy link
Contributor Author

I've added a changeset so I think this is OK to merge now!

@sonalideshpandemsft sonalideshpandemsft merged commit eefd998 into microsoft:next May 16, 2023
@ChumpChief ChumpChief deleted the RemoveDeprecatedCRDefs branch May 16, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: runtime Runtime related issues base: next PRs targeted against next branch breaking change This PR or issue would introduce a breaking change changeset-required PR requires a changeset msftbot: merge-next public api change Changes to a public API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants