Config Schema Updates to NotificationInfo.To #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion PR to the config.schema.json changes made in the MEF. The changes aren't apparent, since the MEF has yet to be updated, but this is where changes to the version of the MEF will live after local testing.
To test, either point the electron app's MEF dependency to your local version of the MEF, or update the MEF branch to point at
#json-schema-notif-to-fix. Once you've done that and rerunnpm install, you should be able to see the changes to the notificationInfo.to property. The goal of testing should be to ensure that the titles associated with the config schema make it easier to understand where the To information should live.Once testing is done and a merge is complete on the MEF PR, we need to update our package-lock file. Then we should be good to merge.