Skip to content

Conversation

@Dtphelan1
Copy link
Contributor

Minor updates to our config file schema. Updates the .notificationInfo.to property so that:

  1. The AnyOf is changed to OneOf, which is more in line with what we want. For detailed explanations on the difference between these, see here.
  2. Each of the OneOf options have a title associated with them. This improves the result of rendering these options by React JSON Schema Form, which is used by the extraction-ui. A companion PR exists there and also needs to be reviewed.

Testing here should ensure that everything works as it previously did. Additionally, before merging these changes, we should review the extraction-ui and ensure that the visual changes look as desired.

Copy link
Contributor

@jafeltra jafeltra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comments about the wording, but this works as expected in the UI app!

Copy link
Contributor

@jafeltra jafeltra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me and works in the app!

@jafeltra jafeltra merged commit 806d3bc into develop Oct 7, 2021
@jafeltra jafeltra deleted the json-schema-notif-to-fix branch October 7, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants