Skip to content

Conversation

@julianxcarter
Copy link
Collaborator

This PR introduces a picker for the mask constructorArg within the patientExtractor config section of the Config Editor. Though they're not currently functional, the mask values that will soon be added to the MEF are included options as well.

@Dtphelan1 Dtphelan1 self-assigned this Oct 6, 2021
@Dtphelan1
Copy link
Contributor

DP1 - We could probably update the MEF version now 😄

@Dtphelan1
Copy link
Contributor

DP2 - Needs a rebase

@Dtphelan1
Copy link
Contributor

DP3 - Small thing, but I noticed that if you click on the label of a checkbox (e.g. the text-label telecom next to the checkbox) it alternates the checked-value for the wrong field. After doing some digging, I learned that providing an id prop to the Form.Check component will solve this issue (see react-bootstrap/react-bootstrap#4056 (comment)).

tl;dr let's add an id prop to the Form.Check component that's identical with the key prop.

@Dtphelan1
Copy link
Contributor

Other than that this looks good to me! We do a lot of extraneous state-management in this component, and we could probably do away with some/most of it; but that's not introduced by this PR and should be evaluated independently. I'll make a task for that 😄

@Dtphelan1
Copy link
Contributor

I think this looks good – great work Julian!

@Dtphelan1 Dtphelan1 merged commit cebe8d6 into master Oct 11, 2021
@Dtphelan1 Dtphelan1 deleted the mask-picker branch October 11, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants