Skip to content

Conversation

@SenecaAnderson
Copy link
Contributor

Summary

The function mcodeApp in src/cli/app.js was modified to return the extractedData object instead of writing the results to a file. src/cli/cli.js was modified to write the results of calling mocdeApp to a file.

New behavior

cli.js writes the results of extraction to a file instead of app.js.

Code changes

The code to write to a file was moved from app.js to cli.js and replaced with a return statement.

Testing guidance

Use 'npm start' to run extraction.

@mgramigna
Copy link
Contributor

I see there are some linter errors being caught by Github actions here. We have a pretty strict linter set up in the MEF, which allows us to enforce code style and make sure the syntax is correct.

You can configure VS Code to show you the lint errors by installing this extension: https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint

Once you do, you should see some errors in the editor that should need to be resolved. You can also check lint locally with the npm script we've added:

npm run lint

We also have a command that will fix and automatically fixable lint issues:

npm run lint-fix

@mgramigna
Copy link
Contributor

Other than the lint errors and the change request I made, this looks good and works as expected

@jafeltra jafeltra self-assigned this Jun 4, 2021
Copy link
Contributor

@jafeltra jafeltra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jafeltra jafeltra merged commit 5b22683 into develop Jun 4, 2021
@jafeltra jafeltra deleted the return-extracted-data branch June 4, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants