Revert 22092 changes in 2.2-dev due to oom

[XuPeng-SH]

User description

What type of PR is this?

• API-change
• BUG
• Improvement
• Documentation
• Feature
• Test and CI
• Code Refactoring

Which issue(s) this PR fixes:

issue #22151

What this PR does / why we need it:

Revert 22092 changes in 2.2-dev due to oom

---

PR Type

Bug fix

---

Description

• Revert changes from PR enable new DML plan for tables with vector columns #22092 causing OOM issues

• Add vector column DML operation restriction

• Import types package for array type checking

---

Changes diagram

flowchart LR
  A["Import types package"] --> B["Check column types"]
  B --> C["Block vector column DML"]
  C --> D["Prevent OOM issues"]

Loading

---

Changes walkthrough 📝

	Relevant files
Bug fix	dml_context.go Add vector column DML restriction                                                pkg/sql/plan/dml_context.go Add import for types package Add validation loop to check column types Return error for vector/array columns in DML operations +7/-0

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Error Message The error message "vector column" is inconsistent with the check logic which uses IsArrayRelate() method. This could confuse users since the method checks for array-related types but reports "vector column" error. return moerr.NewUnsupportedDML(ctx.GetContext(), "vector column") } Logic Placement The vector/array column check is placed after foreign key validation but before cluster table checks. Consider if this is the optimal placement for performance and logical flow. for _, col := range tableDef.Cols { if types.T(col.Typ.Id).IsArrayRelate() { return moerr.NewUnsupportedDML(ctx.GetContext(), "vector column") } }

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Fix misleading error message The error message "vector column" is misleading since the check uses IsArrayRelate() which covers both vector and array types. Update the error message to accurately reflect what types are being rejected. pkg/sql/plan/dml_context.go [233-237] for _, col := range tableDef.Cols { if types.T(col.Typ.Id).IsArrayRelate() { - return moerr.NewUnsupportedDML(ctx.GetContext(), "vector column") + return moerr.NewUnsupportedDML(ctx.GetContext(), "vector/array column") } } Apply / Chat Suggestion importance[1-10]: 6 __ Why: The suggestion correctly identifies that the error message "vector column" is misleading because the check IsArrayRelate() covers both vector and array types, so the proposed change improves clarity.	Low
More