enable new DML plan for tables with vector columns

[aunjgr]

User description

What type of PR is this?

• API-change
• BUG
• Improvement
• Documentation
• Feature
• Test and CI
• Code Refactoring

Which issue(s) this PR fixes:

issue #22020

What this PR does / why we need it:

refactored DML has better support for REPLACE INTO SELECT

---

PR Type

Enhancement

---

Description

• Remove vector column restriction from DML operations

• Enable new DML plan for tables with vector columns

---

Changes diagram

flowchart LR
  A["DML Context"] --> B["Table Resolution"]
  B --> C["Vector Column Check"]
  C --> D["Remove Restriction"]
  D --> E["Enable New DML Plan"]

Loading

---

Changes walkthrough 📝

	Relevant files
Enhancement	dml_context.go Remove vector column DML restriction                                          pkg/sql/plan/dml_context.go Remove import of types package Delete vector column validation loop in ResolveSingleTable Remove error return for vector column unsupported DML +0/-7

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Missing Validation The removal of vector column validation may enable DML operations on vector columns without proper testing or verification that the new DML plan actually supports these operations correctly. This could lead to runtime errors or data corruption if the underlying implementation is not ready. if checkFK && (len(tableDef.Fkeys) > 0 || len(tableDef.RefChildTbls) > 0) { return moerr.NewUnsupportedDML(ctx.GetContext(), "foreign key constraint") } isClusterTable := util.TableIsClusterTable(tableDef.GetTableType()) accountId, err := ctx.GetAccountId() if err != nil { return err

[qodo-merge-pro]

PR Code Suggestions ✨

No code suggestions found for the PR.