Support sending delayed events (Futures) / MSC4157 #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
AndrewFerr
added a commit
to matrix-org/matrix-js-sdk
that referenced
this pull request
Jun 28, 2024
Widget changes require matrix-org/matrix-widget-api#90
4 tasks
toger5
reviewed
Jul 3, 2024
toger5
reviewed
Jul 3, 2024
toger5
reviewed
Jul 3, 2024
toger5
reviewed
Jul 3, 2024
Remove "send_future" types in favour of extending "send_event"
|
@AndrewFerr Thanks for the quick implementation update to the MSC change we discussed! |
toger5
reviewed
Jul 8, 2024
toger5
reviewed
Jul 8, 2024
There was a problem hiding this comment.
Looks good.
We are lacking tests.
I think the most important piece to be tested is the handleSendEvent call from the ClientWidgetApi.
I also added a very optional comment on the code style of the stacked if.
Take this as a proposal only (not even sure if it would be better or if I just would prefer it)
with timeout coming first because all future groups require a timeout.
to increase code reuse
as proposed by MSC4157
AndrewFerr
added a commit
to matrix-org/matrix-js-sdk
that referenced
this pull request
Jul 10, 2024
Widget changes require matrix-org/matrix-widget-api#90
AndrewFerr
changed the title
5 tasks
AndrewFerr
added a commit
to matrix-org/matrix-js-sdk
that referenced
this pull request
Jul 11, 2024
4 tasks
AndrewFerr
added a commit
to matrix-org/matrix-js-sdk
that referenced
this pull request
Jul 12, 2024
|
The latest commit adds tests for sending futures (and non-future events too, which never had tests), so this should be good for now. |
4 tasks
AndrewFerr
added a commit
to matrix-org/matrix-js-sdk
that referenced
this pull request
Jul 17, 2024
AndrewFerr
added a commit
to matrix-org/matrix-js-sdk
that referenced
this pull request
Jul 26, 2024
AndrewFerr
added a commit
to matrix-org/matrix-js-sdk
that referenced
this pull request
Jul 26, 2024
AndrewFerr
added a commit
to matrix-org/matrix-js-sdk
that referenced
this pull request
Jul 30, 2024
Widget changes require matrix-org/matrix-widget-api#90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Ferrazzutti [email protected]