-
Notifications
You must be signed in to change notification settings - Fork 411
MSC4140: Cancellable delayed events #4140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
toger5
wants to merge
119
commits into
main
Choose a base branch
from
toger5/expiring-events-keep-alive
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+818
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
2bc07c4
to
0eb1abc
Compare
Signed-off-by: Timo K <[email protected]>
0eb1abc
to
8bf6db7
Compare
Signed-off-by: Timo K <[email protected]>
AndrewFerr
reviewed
May 8, 2024
Signed-off-by: Timo K <[email protected]>
3e54c2a
to
c82adf7
Compare
Signed-off-by: Timo K <[email protected]>
c82adf7
to
54fff99
Compare
…is used to trigger on of the actions Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Add event type to the body Add event id template variable
MatMaul
reviewed
May 20, 2024
toger5
commented
May 20, 2024
AndrewFerr
reviewed
May 22, 2024
AndrewFerr
reviewed
May 23, 2024
AndrewFerr
reviewed
May 30, 2024
Co-authored-by: Andrew Ferrazzutti <[email protected]>
richvdh
reviewed
Oct 1, 2025
richvdh
reviewed
Oct 1, 2025
Redundant because GitHub's Markdown viewer provides its own ToC. Stale because some of the headings refered to absent sections.
but state events are still used in the MatrixRTC section
AndrewFerr
reviewed
Oct 9, 2025
AndrewFerr
reviewed
Oct 9, 2025
It is either the send time, or the cancel/error time
itsoyou
pushed a commit
to famedly/synapse
that referenced
this pull request
Oct 13, 2025
… v11 using the /send endpoint (#18898) Implement [MSC4169](matrix-org/matrix-spec-proposals#4169) While there is a dedicated API endpoint for redactions, being able to send redactions using the normal send endpoint is useful when using [MSC4140](matrix-org/matrix-spec-proposals#4140) for sending delayed redactions to replicate expiring messages. Currently this would only work on rooms >= v11 but fail with an internal server error on older room versions when setting the `redacts` field in the content, since older rooms would require that field to be outside of `content`. We can address this by copying it over if necessary. Relevant spec at https://spec.matrix.org/v1.8/rooms/v11/#moving-the-redacts-property-of-mroomredaction-events-to-a-content-property --------- Co-authored-by: Tulir Asokan <[email protected]>
tulir
reviewed
Oct 13, 2025
Content-Type: application/json | ||
|
||
{ | ||
"scheduled": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is still called delayed_events
in the Synapse implementation: https://github.com/element-hq/synapse/blob/v1.140.0rc1/synapse/rest/client/delayed_events.py#L103, should mention that in the unstable prefix section. It was renamed in 904e3d6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
client-server
Client-Server API
implementation-needs-checking
The MSC has an implementation, but the SCT has not yet checked it.
kind:feature
MSC for not-core and not-maintenance stuff
matrix-2.0
Required for Matrix 2.0
proposal
A matrix spec change proposal
voip
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
This could also supersede MSC2228 (by making it possible to send a redaction with the
/send
endpoint. This is the case as mentioned here)Implementations:
SCT stuff:
checklist
FCP not yet started
Blocked: #4140 (comment)