Skip to content

Update datepicker & timepicker "container" option to allow being specified the same way #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 10, 2021
Merged

Update datepicker & timepicker "container" option to allow being specified the same way #69

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6d34cf8
Allow datepicker to use both query selector and element
Cerothen Feb 12, 2021
aa0d2ac
Allow timepicker container to be an element
Cerothen Feb 12, 2021
3d8dda3
Update pickers_content.html
Cerothen May 9, 2021
6472955
Update pickers_content.html
Cerothen May 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions js/datepicker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,8 @@
this.cancelBtn.innerHTML = this.options.i18n.cancel;

if (this.options.container) {
const optEl = this.options.container;
this.options.container = (optEl instanceof HTMLElement?optEl:document.querySelector(optEl));
this.$modalEl.appendTo(this.options.container);
} else {
this.$modalEl.insertBefore(this.el);
Expand Down
3 changes: 2 additions & 1 deletion js/timepicker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,8 @@
this.modalEl.id = 'modal-' + this.id;

// Append popover to input by default
let containerEl = document.querySelector(this.options.container);
const optEl = this.options.container;
let containerEl = (optEl instanceof HTMLElement?optEl:document.querySelector(optEl));
if (this.options.container && !!containerEl) {
this.$modalEl.appendTo(containerEl);
} else {
Expand Down