-
-
Notifications
You must be signed in to change notification settings - Fork 107
Update datepicker & timepicker "container" option to allow being specified the same way #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Allow the datepicker to also use the document selector like the timepicker
Allow Timepicker to be used with an element instead of a selector string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the doc (jade/page-contents/pickers_content.html) for both the date picker and time picker need to be updated.
For example, in the date picker, the row with "container" in the name column, can be updated like this
Name | Type | Default | Description |
---|---|---|---|
container | Element || String | null | Specify a DOM element to render the calendar in, or a selector string for a DOM element to render the calendar in. By default it will be placed before the input. |
And in the time picker doc, just replace "calendar" with "time picker" in the description.
@Cerothen can you update the files according to the review by @Smankusors? |
Update documentation to reflect the way picker containers
I have updated the documentation as requested. |
@Cerothen Thanks for the PR I also invited you to the materializecss org. Welcome! 😃 |
Proposed changes
The datepicker and timepicker have containers that are specified in different ways (datepicker = element, timepicker = document query selector string). These changes allow both to have the container specified by either an element or a query string for both elements to maintain backward compatability while also harmonizing the entry method.
Types of changes
Checklist: