Skip to content

Tabs with Icons #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 24, 2024
Merged

Tabs with Icons #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6913317
fix: tab was not selected when clicked in the icon
danice Oct 24, 2024
6242adc
fix: styles for tabs with icons + text
danice Nov 23, 2024
655b58c
fix: display icons vertically centered by default
danice Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 31 additions & 5 deletions sass/components/_tabs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@

position: relative;
overflow-x: auto;
overflow-y: hidden;
height: 48px;
overflow-y: hidden;
width: 100%;
background-color: var(--md-sys-color-surface);
margin: 0 auto;
Expand All @@ -56,11 +55,21 @@
list-style-type: none;
display: inline-block;
text-align: center;
line-height: 48px;
height: 48px;
line-height: 48px;
padding: 0;
margin: 0;

i.material-icons {
position: relative;
top: 8px;
vertical-align: middle;
}

span {
height: 24px;
line-height: 20px;
}

a {
&.active {
background-color: transparent;
Expand All @@ -83,9 +92,11 @@
}

color: var(--md-sys-color-on-surface-variant);
display: block;
display: flex;
flex-direction: column;
width: 100%;
height: 100%;
min-height: 48px; //needed for only-icons tabs
padding: 0 24px;
font-size: 14px;
text-overflow: ellipsis;
Expand All @@ -112,6 +123,21 @@
will-change: left, right;
border-radius: 3px 3px 0 0;
}

&.tabs-horizontal .tab {
height: 48px;

a {
display: block;
}

i.material-icons {
padding: 0 4px;
position: relative;
top: -2px;
vertical-align: middle;
}
}
}

/* Fixed Sidenav hide on smaller */
Expand Down
12 changes: 10 additions & 2 deletions src/tabs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,16 @@ export class Tabs extends Component<TabsOptions> {
}

_handleTabClick = (e: MouseEvent) => {
const tabLink = e.target as HTMLAnchorElement;
const tab = tabLink.parentElement;
let tabLink = e.target as HTMLAnchorElement;

if (!tabLink)
return;
var tab = tabLink.parentElement;
while (tab && !tab.classList.contains('tab')) {
tabLink = tabLink.parentElement as HTMLAnchorElement;
tab = tab.parentElement;
}

// Handle click on tab link only
if (!tabLink || !tab.classList.contains('tab')) return;
// is disabled?
Expand Down