Skip to content

Conversation

danice
Copy link

@danice danice commented Nov 24, 2024

Proposed changes

Adding the options to include icons to tabs.
Changes:

  • css rules for vertial and horizontal text positions
  • fix for a small issue of tab not being selected when the icon was clicked.
  • updated documentation (in a separated PR in materialize-docs)

Note:
Following M3 Tabs specification, tabs appear vertically-centered by default.

Screenshots (if appropriate) or codepen:

imagen

Types of changes

  • Bug fix (non-breaking change which fixes an issue).

  • New feature (non-breaking change which adds functionality).

  • Breaking change (fix or feature that would cause existing functionality to change).

  • I have read the CONTRIBUTING document.

  • My commit messages follows the conventional commit format

  • My change requires a change to the documentation, and updated it accordingly. (Done)

  • I have added tests to cover my changes.

  • All new and existing tests passed.

@danice danice mentioned this pull request Nov 24, 2024
8 tasks
Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please use const instead of var whenever possible.

@wuda-io wuda-io merged commit 1b536e1 into materializecss:v2-dev Nov 24, 2024
1 check passed
@wuda-io
Copy link
Member

wuda-io commented Nov 24, 2024

Thanks for the new PR! Sorry, there were some changes in the old PR, so I could not easily merge it without affecting other code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants