Update main fixes into V2 dev branch #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve slider support to assistive technologies (e.g.: screen readers):
- Add "pause" options to slider initialization:
- pauseOnFocus: Slider should pause when receive keyboard focus;
- pauseOnHover: Slider should pause when hovered by mouse;
- New "indicatorLabelFunc": Must generate ARIA labels for indicators;
- New eventPause prop: is true if slider is paused by focus/hover event;
- Slider must receive id if does not have one;
- Sliders are able to receive focus by code;
- Non-current slides are also hidden in CSS (also from screen readers);
- Add button to indicators:
- Update CSS;
- Update event handlers.
- Indicator click should focus current slide.
Implement slider tests: - Add HTML test implementation for Slider; - Add jasmine test spec for Slider (js + fixture).
- Add description for new initialization options; - Add description for new instance properties; - Add alternative text for images (updating code samples); - Update Slider init code sample to include indicatorLabelFunc example.
- Add missing indicatorLabelFunc prop to Slider#options; - Replace double quotes string by single quotes; - Replace vanilla JS calls by jQuery functions.
- Replace double quotes string by single quotes; - Replace vanilla JS calls by jQuery functions.
Mark "indicatorLabelFunc" as optional in docs description and code samples.
Slider accessibility
Release 1.2.2
documentation links to relative links
fix: navbar-link, workflow and serve docs directly via grunt
Refactor tabs: cleaned code and removed jquery also removed hashing function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Pulled the changes from main into the dev branch.
Types of changes
Checklist: