Promovicz patches #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 21, 2021 13:01
…1fab fix cast in number formatter. Was: retroprom/es40@4dcd65e
RaymiiOrg
force-pushed
the
promovicz_patches
branch
from
0e6a490 to
c1d7d3c
Compare
Closed
lenticularis39
approved these changes
Jan 21, 2021
Owner
lenticularis39
left a comment
lenticularis39
left a comment
There was a problem hiding this comment.
Looks fine. I did some integer type changes myself at the beginning of the fork, but didn't check for the mismatch extensively, so I fixed it only at places where the compiler complained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant commits as in issue #55 . Skipped over the parenthesis and std::string, due to not being a warning now and the std::string static storage could throw an exception.