Check for writable Diskfile #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaymiiOrg
force-pushed
the
ide_check_writable_file
branch
2 times, most recently
from
b8a1173 to
12a23e8
Compare
lenticularis39
approved these changes
Nov 15, 2020
Owner
lenticularis39
left a comment
lenticularis39
left a comment
There was a problem hiding this comment.
Please rebase this onto the main branch to resolve the merge conflict with the other PR.
added 2 commits
November 15, 2020 09:13
…only Using ofstream + is_open in append mode should give us only true if the open() call in append mode succeeded. C++ 17 has std::filesystem::permissions, but this should do as well.
RaymiiOrg
force-pushed
the
ide_check_writable_file
branch
from
c96f388 to
03a260a
Compare
Collaborator
Author
|
Should be good now. |
RaymiiOrg
pushed a commit
to RaymiiOrg/axpbox
that referenced
this pull request
Nov 17, 2020
…e_file Check for writable Diskfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #29