fseek in DiskFile.cpp causes segfault (was: Segfault on raspbian 64)

[wboerhout]

So I built axpbox on Raspian 64-bit

uname -a
Linux raspoe 5.4.75-v8+ #1367 SMP PREEMPT Mon Nov 9 15:11:16 GMT 2020 aarch64 GNU/Linux

configure ran as expected. see cfg file below.
on run it segfaults:

pi@raspoe ~ $ sudo /opt/axpbox/build/axpbox run /opt/axpbox/es40.cfg 
sys0(tsunami): $Id: System.cpp,v 1.79 2008/06/12 07:29:44 iamcamiel Exp $
%FLS-F-NOREST: Flash could not be restored from /opt/axpbox/rom/flash.rom
sys0(tsunami): $Id: Flash.cpp,v 1.19 2008/03/24 22:11:50 iamcamiel Exp $
Segmentatiefout

es40.cfg after editing:

pi@raspoe ~ $ cat /opt/axpbox/es40.cfg
sys0 = tsunami
{
  memory.bits = 28;
  rom.srm = "/opt/axpbox/rom/cl67srmrom.exe";
  rom.decompressed = "/opt/axpbox/rom/decompressed.rom";
  rom.flash = "/opt/axpbox/rom/flash.rom";
  rom.dpr = "/opt/axpbox/rom/dpr.rom";

  cpu0 = ev68cb
  {
    speed = 800M;
    icache = false;
    skip_memtest_hack = false;
  }

  serial0 = serial
  {
    port = 21264;
  }

  pci0.15 = ali_ide
  {
  }

  pci0.1 = dec21143
  {
    adapter = "tap1";
    mac = "08-00-2B-E5-40-00";
  }

  pci0.2 = sym53c810
  {
    disk0.0 = file
    {
      file = "/vdisk/VSIAXP.vdisk";
      cdrom = false;
      read_only = false;
    }

    disk0.1 = file
    {
      file = "/vdisk/Tools-RZ22.vdisk";
      cdrom = false;
      read_only = false;
    }

  }

  pci0.7 = ali
  {
    mouse.enabled = false;
    vga_console = false;
  }

  pci0.19 = ali_usb
  {
  }
}

since I used the default build, gdb from the core dump only gives me this:

Thread 1 (LWP 9269):
#0  0xf74fd614 in ?? ()
No symbol table info available.
#1  0x0005c270 in CDiskFile::CDiskFile(CConfigurator*, CSystem*, CDiskController*, int, int) ()
No symbol table info available.
Backtrace stopped: previous frame identical to this frame (corrupt stack?)

I believe at this point it should decompress the ROM ?

[lenticularis39]

Thank you for submitting this.

I believe at this point it should decompress the ROM ?

The ROM is decompressed by the CPU, which is not loaded yet at this phase. The next device that is loaded is the ALi IDE, which would correspond to the CDiskFile::CDiskFile constructor being the location of the segfault. You can try to remove/comment out this section in the configuration file:

  pci0.15 = ali_ide
  {
  }

Could you do a debug build using -DCMAKE_BUILD_TYPE=Debug and perhaps run AXPbox with GDB to get the full stack trace? No disk file should be created for the ALi IDE if its configuration is empty. I tried reproducing the error by commenting out the contents of the ALi IDE configuration, but didn't suceed - AXPbox starts fine for me.

[wboerhout]

removing the ali_ide section from the cfg does not prevent the segfault. I will try and recompile with debug as per your suggestion. May take a whil though since I am not yet familiar with gdb.

[wboerhout]

'''
root@raspoe /opt/axpbox/build # gdb axpbox
GNU gdb (Raspbian 8.2.1-2) 8.2.1
Copyright (C) 2018 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later http://gnu.org/licenses/gpl.html
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Type "show copying" and "show warranty" for details.
This GDB was configured as "arm-linux-gnueabihf".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
http://www.gnu.org/software/gdb/bugs/.
Find the GDB manual and other documentation resources online at:
http://www.gnu.org/software/gdb/documentation/.

For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from axpbox...done.
(gdb) run run /opt/axpbox/es40.cfg
Starting program: /opt/axpbox/build/axpbox run /opt/axpbox/es40.cfg
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/arm-linux-gnueabihf/libthread_db.so.1".
sys0(tsunami): $Id: System.cpp,v 1.79 2008/06/12 07:29:44 iamcamiel Exp $
%FLS-F-NOREST: Flash could not be restored from /opt/axpbox/rom/flash.rom
sys0(tsunami): $Id: Flash.cpp,v 1.19 2008/03/24 22:11:50 iamcamiel Exp $

Program received signal SIGSEGV, Segmentation fault.
__fseeko (fp=0x0, offset=offset@entry=0, whence=whence@entry=2) at fseeko.c:39
39 fseeko.c: Bestand of map bestaat niet.
'''

[wboerhout]

last line is "file does not exist"

[RaymiiOrg]

sys0(tsunami): $Id: System.cpp,v 1.79 2008/06/12 07:29:44 iamcamiel Exp $
%FLS-F-NOREST: Flash could not be restored from /opt/axpbox/rom/flash.rom
sys0(tsunami): $Id: Flash.cpp,v 1.19 2008/03/24 22:11:50 iamcamiel Exp $

Program received signal SIGSEGV, Segmentation fault.
__fseeko (fp=0x0, offset=offset@entry=0, whence=whence@entry=2) at fseeko.c:39
39 fseeko.c: Bestand of map bestaat niet.
'''

Might be a wild guess, but does that file exist:

%FLS-F-NOREST: Flash could not be restored from /opt/axpbox/rom/flash.rom

If there is a file there, you could try to remove it and re-download the rom?

I'm on mobile right now so not able to look further into the issue.

[wboerhout]

No the flash is not there. Where would I get it from? Or did I not read the instrctions right? W Op za 14 nov. 2020 om 17:39 schreef Remy <notifications@github.com>

sys0(tsunami): $Id: System.cpp,v 1.79 2008/06/12 07:29:44 iamcamiel Exp $ %FLS-F-NOREST: Flash could not be restored from /opt/axpbox/rom/flash.rom sys0(tsunami): $Id: Flash.cpp,v 1.19 2008/03/24 22:11:50 iamcamiel Exp $ Program received signal SIGSEGV, Segmentation fault. __fseeko (fp=0x0, ***@***.***=0, ***@***.***=2) at fseeko.c:39 39 fseeko.c: Bestand of map bestaat niet. ''' Might be a wild guess, but does that file exist: %FLS-F-NOREST: Flash could not be restored from /opt/axpbox/rom/flash.rom If there is a file there, you could try to remove it and re-download the rom? I'm on mobile right now so not able to look further into the issue. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#29 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACYSHHJW3ODMOZX7WK7LKSDSP2XDJANCNFSM4TVSQHVQ> .

-- Wilm

[RaymiiOrg]

If you have the srm exe file it should be extracted from there. The specific error could not restore state is only triggered if the flash.rom file is not found as I see in the code.

What happens if you rekove and redownload the cl67srmrom.exe file and try again ?

[RaymiiOrg]

Oh and does the issue also occur when you change the disk controller to ide?

pci0.2 = ali_ide

Instead of

pci0.2 = sym53c810

(even though you just removed the empty ide block)

[wboerhout]

the segfault occurs the first time I run the axpbox (and also after that)

pi@raspoe ~ $ grep rom /opt/axpbox/es40.cfg
  rom.srm = "/opt/axpbox/rom/cl67srmrom.exe";
  rom.decompressed = "/opt/axpbox/rom/decompressed.rom";
  rom.flash = "/opt/axpbox/rom/flash.rom";
  rom.dpr = "/opt/axpbox/rom/dpr.rom";
      cdrom = false;
      cdrom = false;
pi@raspoe ~ $ ll /opt/axpbox/rom/cl67srmrom.exe
-rwxrwxrwx 1 root root 693248 sep 27 13:17 /opt/axpbox/rom/cl67srmrom.exe

[wboerhout]

I deleted cls67srmrom.exe and did a new

wget https://raymii.org/s/inc/downloads/es40-srmon/cl67srmrom.exe

no change, still segfault. You said this all happens before the Alpha cpu can uncompress the rom. It never gets there, right?

[lenticularis39]

Yes, it doesn't even get to the ROM uncompressing - that happens much later in the process after all peripherals are initialized (see for example the log here for how a successful start looks like).

If you type "bt" when GDB stops at the segfault, it should print the whole stack trace, showing which component caused the error.

[wboerhout]

(gdb) run run /opt/axpbox/es40.cfg 
Starting program: /opt/axpbox/build/axpbox run /opt/axpbox/es40.cfg
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/arm-linux-gnueabihf/libthread_db.so.1".
sys0(tsunami): $Id: System.cpp,v 1.79 2008/06/12 07:29:44 iamcamiel Exp $
%FLS-F-NOREST: Flash could not be restored from /opt/axpbox/rom/flash.rom
sys0(tsunami): $Id: Flash.cpp,v 1.19 2008/03/24 22:11:50 iamcamiel Exp $

Program received signal SIGSEGV, Segmentation fault.
__fseeko (fp=0x0, offset=offset@entry=0, whence=whence@entry=2) at fseeko.c:39
39	fseeko.c: Bestand of map bestaat niet.
(gdb) bt
#0  __fseeko (fp=0x0, offset=offset@entry=0, whence=whence@entry=2) at fseeko.c:39
#1  0x00058090 in CDiskFile::CDiskFile (this=0xe6998008, cfg=<optimized out>, sys=<optimized out>, c=<optimized out>, idebus=0, 
    idedev=0) at /opt/axpbox/src/DiskFile.cpp:155
#2  0x0004c8dc in CConfigurator::initialize (this=0xe2460) at /opt/axpbox/src/Configurator.h:146
#3  0x0004c4e4 in CConfigurator::initialize (this=0xe2228) at /opt/axpbox/src/Configurator.cpp:918
#4  0x0004c4e4 in CConfigurator::initialize (this=0xe1780) at /opt/axpbox/src/Configurator.cpp:918
#5  0x0004db88 in CConfigurator::CConfigurator (this=<optimized out>, parent=0x0, name=<optimized out>, value=<optimized out>, 
    text=0xe1218 "sys0=tsunami{memory.bits=28;rom.srm=\"/opt/axpbox/rom/cl67srmrom.exe\";rom.decompressed=\"/opt/axpbox/rom/decompressed.rom\";rom.flash=\"/opt/axpbox/rom/flash.rom\";rom.dpr=\"/opt/axpbox/rom/dpr.rom\";cpu0=ev"..., textlen=563)
    at /opt/axpbox/src/Configurator.cpp:445
#6  0x000457f4 in main_sim (argc=argc@entry=2, argv=argv@entry=0xfffef798) at /opt/axpbox/src/AlphaSim.cpp:313
#7  0x0005c808 in main (argc=3, argv=0xfffef798) at /opt/axpbox/src/Main.cpp:23

at start, the only file in the rom directory is cl67srmrom.exe

[lenticularis39]

This is definitely a bug in disk file handling, guessing something like fopen failing while ifstream reporting the file being accessible.