internal(eslint): resolve eslint warnings and errors #8772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This was referenced Aug 25, 2025
hntrl
approved these changes
Sep 9, 2025
Comment on lines
38
to
43
| # Install @langchain/google-gauth dependency explicitly | ||
| # This is needed because the update script converts the workspace dependency | ||
| # to use the minimum version, but in the test environment we need to install | ||
| # it as a regular dependency since workspace packages aren't available | ||
| pnpm add @langchain/google-gauth | ||
| pnpm test |
There was a problem hiding this comment.
I think this will lead to a bunch of false positives? We purposefully want to use the lowest version of the package for -gauth published on the registry
There was a problem hiding this comment.
yep, will revert this as I improved environment tests in a different PR.
|
christian-bromann
merged commit a0d1a43
into
cb/v1-eslint-update-adoption
109 of 111 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last patch fixes a lot of Eslint problems we had in our project. The most common ones are the following:
try/catchblock