internal(eslint): adopt new internal eslint package #8771
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
FYI: I have stacked the entire change in multiple PRs so this branch is failing - the final PR (#8772) is passing all pipelines. |
| "serve": "docusaurus serve", | ||
| "write-translations": "docusaurus write-translations", | ||
| "write-heading-ids": "docusaurus write-heading-ids", | ||
| "lint:eslint": "NODE_OPTIONS=--max-old-space-size=4096 eslint --cache --ext .ts,.js src/", |
There was a problem hiding this comment.
probably fine, but I half expect eslint to start erroring after this since the typescript process that eslint runs chews on a lot of memory
There was a problem hiding this comment.
Happy to bring it back but I assume with us relying on a new Node.js version and Eslint v9 having some performance improvements, I don't think we will run into these. Happy to bring it back though if we do.
examples/package.json
Outdated
| "postinstall": "prisma generate --schema ./src/indexes/vector_stores/prisma_vectorstore/prisma/schema.prisma", | ||
| "start:dist": "pnpm build && node -r dotenv/config dist/index.js", | ||
| "lint:eslint": "NODE_OPTIONS=--max-old-space-size=4096 eslint --cache --ext .ts,.js src/", | ||
| "lint:eslint": "eslint --cache src/", |
There was a problem hiding this comment.
| "lint:eslint": "eslint --cache src/", | |
| "lint:eslint": "eslint --cache src/", |
| "@typescript-eslint/eslint-plugin": "^5.51.0", | ||
| "@typescript-eslint/parser": "^5.51.0", | ||
| "eslint": "^8.33.0", | ||
| "eslint-config-airbnb-base": "^15.0.0", | ||
| "eslint-config-prettier": "^8.6.0", | ||
| "eslint-plugin-import": "^2.27.5", | ||
| "eslint-plugin-prettier": "^4.2.1", | ||
| "eslint-plugin-unused-imports": "^3.0.0", |
| "scripts": { | ||
| "test:int": "vitest run --config=example/vitest.config.ts", | ||
| "lint": "eslint --cache --ext .ts,.js src/", | ||
| "lint": "eslint --cache src/", |
There was a problem hiding this comment.
| "lint": "eslint --cache src/", | |
| "lint": "eslint --cache src/", |
| "scripts": { | ||
| "build": "pnpm --filter @langchain/build compile @langchain/community", | ||
| "lint:eslint": "NODE_OPTIONS=--max-old-space-size=4096 eslint --cache --ext .ts,.js src/", | ||
| "lint:eslint": "eslint --cache src/", |
There was a problem hiding this comment.
| "lint:eslint": "eslint --cache src/", | |
| "lint:eslint": "eslint --cache src/", |
libs/langchain-core/package.json
Outdated
| "build": "pnpm --filter @langchain/build compile @langchain/core", | ||
| "clean": "rm -rf .turbo dist/", | ||
| "lint:eslint": "NODE_OPTIONS=--max-old-space-size=4096 eslint --cache --ext .ts,.js src/", | ||
| "lint:eslint": "eslint --cache src/", |
|
2 participants
In this PR we are updating the new Eslint package introduced in #8770. This patch:
NODE_OPTIONSenv which is not neededeslint.config.tsin every project.eslintrc.cjsfiles