Skip to content

refactor: update to use a pydantic field to be safer #31942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

refactor: update to use a pydantic field to be safer #31942

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
07725ae
retrievers: update to use a pydantic field
MichaelLi65535 Jul 9, 2025
75391cd
Merge branch 'master' into retrievers/update-field-pydantic
MichaelLi65535 Jul 10, 2025
65065aa
Merge branch 'master' into retrievers/update-field-pydantic
MichaelLi65535 Jul 11, 2025
7e39801
Merge branch 'master' into retrievers/update-field-pydantic
MichaelLi65535 Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/langchain/langchain/retrievers/time_weighted_retriever.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class TimeWeightedVectorStoreRetriever(BaseRetriever):
k: int = 4
"""The maximum number of documents to retrieve in a given call."""

other_score_keys: list[str] = []
other_score_keys: list[str] = Field(default_factory=list)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of Field we should be using field

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichaelLi65535

"""Other keys in the metadata to factor into the score, e.g. 'importance'."""

default_salience: Optional[float] = None
Expand Down
Loading