-
Notifications
You must be signed in to change notification settings - Fork 18.6k
refactor: update to use a pydantic field to be safer #31942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update to use a pydantic field to be safer #31942
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
CodSpeed WallTime Performance ReportMerging #31942 will not alter performanceComparing
|
CodSpeed Instrumentation Performance ReportMerging #31942 will not alter performanceComparing Summary
|
@@ -37,7 +37,7 @@ class TimeWeightedVectorStoreRetriever(BaseRetriever): | |||
k: int = 4 | |||
"""The maximum number of documents to retrieve in a given call.""" | |||
|
|||
other_score_keys: list[str] = [] | |||
other_score_keys: list[str] = Field(default_factory=list) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of Field
we should be using field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing to LangChain!
PR title: "package: description"
PR message: Delete this entire checklist and replace with
Add tests and docs: If you're adding a new integration, please include
docs/docs/integrations
directory.Lint and test: Run
make format
,make lint
andmake test
from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/Additional guidelines:
If no one reviews your PR within a few days, please @-mention one of baskaryan, eyurtsev, ccurme, vbarda, hwchase17.