refactor(pihole): reduce cyclomatic complexity of TestProvider #5865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clomatic complexity - Split monolithic TestProvider into four focused test functions: - TestProvider_InitialState: tests empty provider state - TestProvider_CreateRecords: tests record creation - TestProvider_DeleteRecords: tests record deletion - TestProvider_UpdateRecords: tests record updates - Each function tests a single scenario, reducing complexity - Preserves all original test logic and maintains 89% coverage - Passes cyclop linter with complexity threshold of 10
k8s-ci-robot
added
cncf-cla: yes
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
k8s-ci-robot
added
the
lgtm
mloiseleur
approved these changes
Sep 25, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mloiseleur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
ivankatliarchuk
added a commit
to gofogo/k8s-sigs-external-dns-fork
that referenced
this pull request
Oct 8, 2025
* master: (175 commits) chore(deps): bump renovatebot/github-action (kubernetes-sigs#5890) chore(cloudflare): migrate DeleteCustomHostname() to new lib (kubernetes-sigs#5880) docs(advanced): configuration precedence (kubernetes-sigs#5871) test: update goversion label to 1.25 in metrics test (kubernetes-sigs#5886) ci(linter): add go-critic (kubernetes-sigs#5875) docs(providers): add info about Myra protection option and docker image (kubernetes-sigs#5879) refactor(pihole): reduce cyclomatic complexity of TestProviderV6 (kubernetes-sigs#5876) test(source/service): add serviceTypeFilter edge case (kubernetes-sigs#5872) chore(ci): speed-up & coveralls (kubernetes-sigs#5870) feat(provider/cloudflare): add support for tags (kubernetes-sigs#5862) chore(deps): bump renovatebot/github-action (kubernetes-sigs#5874) feat: add new flags to allow migration of OwnerID (kubernetes-sigs#4823) docs(volcengine): add volcengine provider to readme (kubernetes-sigs#5866) chore(deps): bump renovatebot/github-action (kubernetes-sigs#5856) docs improve txt registry documentation formatting and examples for apex record (kubernetes-sigs#5863) chore: upgrade ExternalDNS to go v1.25 and golangci-lint v2.5 (kubernetes-sigs#5869) refactor(pihole): reduce cyclomatic complexity of TestProvider (kubernetes-sigs#5865) refactor(service): reduce cyclomatic complexity of extractHeadlessEndpoints (kubernetes-sigs#5822) test(cloudflare): clear environment variables before setting test values (kubernetes-sigs#5851) fix(endpoint/source) Allow '.' in TXT Records (kubernetes-sigs#5844) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Reduces the cyclomatic complexity of TestProvider from 43. The next highest is TestProviderV6 with a complexity of 43
Motivation
Addresses #5419
More