Skip to content

fix(endpoint/source) Allow '.' in TXT Records #5844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 21, 2025
Merged

fix(endpoint/source) Allow '.' in TXT Records #5844

merged 4 commits into from
Sep 21, 2025

Conversation

@onelapahead
Copy link
Contributor

What does it do ?

Fixes a bug that prevents users from ending TXT record targets (and NAPTR) records with . , particularly via the DNSEndpoint source which allows users to define TXT records containing arbitrary text.

Motivation

Works towards closing #5742 and #5741 . Originally included within #5740 but pulled out as a separate, smaller bug fix.

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly - N/A

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 17, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 17, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @onelapahead. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 17, 2025
mloiseleur
mloiseleur reviewed Sep 17, 2025
View reviewed changes
Copy link
Collaborator

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 17, 2025
ivankatliarchuk
ivankatliarchuk suggested changes Sep 17, 2025
View reviewed changes
source/crd.go Outdated
illegalTarget := false
for _, target := range ep.Targets {
isNAPTR := ep.RecordType == endpoint.RecordTypeNAPTR
isTXT := ep.RecordType == endpoint.RecordTypeTXT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any chance we move this out of the targets loop?

ivankatliarchuk
ivankatliarchuk suggested changes Sep 17, 2025
View reviewed changes
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 17, 2025
ivankatliarchuk
ivankatliarchuk reviewed Sep 19, 2025
View reviewed changes
Copy link
Member

@ivankatliarchuk ivankatliarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems interesting, but it feels a bit overengineered, so I’m not sure.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 19, 2025
@onelapahead
Copy link
Contributor Author

@ivankatliarchuk sure thing reverted it back

ivankatliarchuk
ivankatliarchuk reviewed Sep 20, 2025
View reviewed changes
Copy link
Member

@ivankatliarchuk ivankatliarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2025
@mloiseleur
Copy link
Collaborator

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit ef62107 into kubernetes-sigs:master Sep 21, 2025
15 checks passed
ivankatliarchuk added a commit to gofogo/k8s-sigs-external-dns-fork that referenced this pull request Oct 8, 2025
@ivankatliarchuk
Merge branch 'master' into chore-service-fqdn-5549
b7d75af 
* master: (175 commits)
  chore(deps): bump renovatebot/github-action (kubernetes-sigs#5890)
  chore(cloudflare): migrate DeleteCustomHostname() to new lib (kubernetes-sigs#5880)
  docs(advanced): configuration precedence (kubernetes-sigs#5871)
  test: update goversion label to 1.25 in metrics test (kubernetes-sigs#5886)
  ci(linter): add go-critic (kubernetes-sigs#5875)
  docs(providers): add info about Myra protection option and docker image (kubernetes-sigs#5879)
  refactor(pihole): reduce cyclomatic complexity of TestProviderV6 (kubernetes-sigs#5876)
  test(source/service): add serviceTypeFilter edge case (kubernetes-sigs#5872)
  chore(ci): speed-up & coveralls (kubernetes-sigs#5870)
  feat(provider/cloudflare): add support for tags (kubernetes-sigs#5862)
  chore(deps): bump renovatebot/github-action (kubernetes-sigs#5874)
  feat: add new flags to allow migration of OwnerID (kubernetes-sigs#4823)
  docs(volcengine): add volcengine provider to readme (kubernetes-sigs#5866)
  chore(deps): bump renovatebot/github-action (kubernetes-sigs#5856)
  docs improve txt registry documentation formatting and examples for apex record (kubernetes-sigs#5863)
  chore: upgrade ExternalDNS to go v1.25 and golangci-lint v2.5 (kubernetes-sigs#5869)
  refactor(pihole): reduce cyclomatic complexity of TestProvider (kubernetes-sigs#5865)
  refactor(service): reduce cyclomatic complexity of extractHeadlessEndpoints (kubernetes-sigs#5822)
  test(cloudflare): clear environment variables before setting test values (kubernetes-sigs#5851)
  fix(endpoint/source) Allow '.' in TXT Records (kubernetes-sigs#5844)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mloiseleur mloiseleur mloiseleur left review comments

+1 more reviewer

@ivankatliarchuk ivankatliarchuk ivankatliarchuk requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ivankatliarchuk ivankatliarchuk

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@onelapahead @k8s-ci-robot @mloiseleur @ivankatliarchuk