Skip to content

Make DisablePortSecurity compatible with platforms not using the port… #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 15, 2020
Merged

Make DisablePortSecurity compatible with platforms not using the port… #560

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03b6160
Make DisablePortSecurity compatible with platforms not using the port…
qvicksilver Jun 11, 2020
069eb27
Apply suggestions from code review
qvicksilver Jun 13, 2020
3a6cf61
Remove unused variable
qvicksilver Jun 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions pkg/cloud/services/networking/network.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,15 +58,19 @@ func (s *Service) ReconcileNetwork(clusterName string, openStackCluster *infrav1
}

var portSecurityEnabled gophercloud.EnabledState
var opts createOpts
if openStackCluster.Spec.DisablePortSecurity {
portSecurityEnabled = gophercloud.Disabled
opts = createOpts{
AdminStateUp: gophercloud.Enabled,
Name: networkName,
PortSecurityEnabled: portSecurityEnabled,
}
} else {
portSecurityEnabled = gophercloud.Enabled
}
opts := createOpts{
AdminStateUp: gophercloud.Enabled,
Name: networkName,
PortSecurityEnabled: portSecurityEnabled,
opts = createOpts{
AdminStateUp: gophercloud.Enabled,
Name: networkName,
}
}
network, err := networks.Create(s.client, opts).Extract()
if err != nil {
Expand Down