Skip to content

Conversation

qvicksilver
Copy link
Contributor

… security extension

🐛 (:bug:, patch and bugfixes)

What this PR does / why we need it:
Improves compatibility with OpenStack without the port security extension
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #559

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 11, 2020
@k8s-ci-robot k8s-ci-robot requested review from jichenjc and ncdc June 11, 2020 09:04
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 11, 2020
@qvicksilver
Copy link
Contributor Author

That is my understanding at least, it is the default without the extension and the extension enables you to disable it.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 11, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 13, 2020

Build succeeded.

@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qvicksilver, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2020
@jichenjc
Copy link
Contributor

ok, works for me
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4343958 into kubernetes-sigs:master Jun 15, 2020
@qvicksilver qvicksilver deleted the fix-#559 branch June 15, 2020 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DisablePortSecurity implementation causes incompatitibily issues
4 participants