Skip to content

Conversation

@debjotyms
Copy link
Contributor

Checklist:


Description of your changes:

  • Updated Bengali localization for the following folders:
    • content/bn/about
    • content/bn/started
    • content/bn/distributions
  • Updated the Kubeflow homepage with Bengali localization content.
  • Added a language toggle button to switch between English and Bengali versions on the website.

image

  • Ensured all changes are properly signed off.

Issue:

Fixes: #4092


Labels:

/area website

@google-oss-prow google-oss-prow bot added the area/website AREA: Website Styles/Hosting/Serving label Apr 26, 2025
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@google-oss-prow
Copy link

Hi @debjotyms. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zijianjoy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubeflow org. You can then trigger verification by writing /verify-owners in a comment.

  • RFMVasconcelos
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

@debjotyms
Copy link
Contributor Author

I have copied all the files and folders from the /en to /bn and now localizing one by one. Is that a good approach? If not, then what people usually do in this type of scenarios?

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/remove-lifecycle stale

Thank you for this great effort @debjotyms!
@davidgs @kubeflow/kubeflow-outreach-committee @kubeflow/kubeflow-steering-committee Can we find contributors who can help with reviewing the content ?

@debjotyms We might also add OWNERs for the Bengali localization folder, like in k8s website: https://github.com/kubernetes/website/blob/main/content/bn/OWNERS

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if we really want this. This will be extremely hard to maintain and can easily get outdated based on my experience with docs in other languages before.

@andreyvelich
Copy link
Member

I am not sure if we really want this. This will be extremely hard to maintain and can easily get outdated based on my experience with docs in other languages before.

I noticed that recently Kueue also introduce localization in their website: kubernetes-sigs/kueue#5842
Similar to Kubernetes website.
@tenzen-y @mimowo How do you ensure that Kueue website content is up-to-date ?

I agree that the maintenance might be an issue, but we should at least talk about it.
I feel that this is important enhancement for us to consider, so Kubeflow gets more adoption.

@davidgs
Copy link

davidgs commented Jul 28, 2025

I maintain my website in 4 different languages. I wrote a 'translator' that uses Google translate so that any new content is automatically translated. I can have updated content re-translated simply by deleting the translation file.

@mimowo
Copy link
Contributor

mimowo commented Jul 28, 2025

How do you ensure that Kueue website content is up-to-date ?

We have this Makefile goal i18n-verify which is used to detect if the pages are out-of-sync.

@terrytangyuan
Copy link
Member

Google Translate can translate a page directly so I wonder if that is sufficient: https://translate.google.com/?sl=en&tl=zh-CN&op=websites

@davidgs
Copy link

davidgs commented Jul 28, 2025

If it's in markdown, that won't work. Which is why I wrote the translator.

@terrytangyuan
Copy link
Member

I guess since markdown files are only used as the source and static HTML files are generated for the website, it works fine. Example translation of KF website in Chinese: https://www-kubeflow-org.translate.goog/?_x_tr_sl=en&_x_tr_tl=zh-CN&_x_tr_hl=en&_x_tr_pto=wapp

@davidgs
Copy link

davidgs commented Jul 29, 2025

You absolutely do not want to just translate the generated HTML, since it will be re-generated on the next build. If the Markdown is not translated, then any changes to the static html will be lost on rebuild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature(localization): Bengali Localization for Kubeflow Docs

6 participants