-
Notifications
You must be signed in to change notification settings - Fork 870
[bn] Add language toggle functionality & partial Bengali localization #4094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…calization Signed-off-by: Debjoty Mitra <[email protected]>
…e page. Signed-off-by: Debjoty Mitra <[email protected]>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Hi @debjotyms. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubeflow org. You can then trigger verification by writing
|
|
I have copied all the files and folders from the /en to /bn and now localizing one by one. Is that a good approach? If not, then what people usually do in this type of scenarios? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/remove-lifecycle stale
Thank you for this great effort @debjotyms!
@davidgs @kubeflow/kubeflow-outreach-committee @kubeflow/kubeflow-steering-committee Can we find contributors who can help with reviewing the content ?
@debjotyms We might also add OWNERs for the Bengali localization folder, like in k8s website: https://github.com/kubernetes/website/blob/main/content/bn/OWNERS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if we really want this. This will be extremely hard to maintain and can easily get outdated based on my experience with docs in other languages before.
I noticed that recently Kueue also introduce localization in their website: kubernetes-sigs/kueue#5842 I agree that the maintenance might be an issue, but we should at least talk about it. |
|
I maintain my website in 4 different languages. I wrote a 'translator' that uses Google translate so that any new content is automatically translated. I can have updated content re-translated simply by deleting the translation file. |
We have this Makefile goal i18n-verify which is used to detect if the pages are out-of-sync. |
|
Google Translate can translate a page directly so I wonder if that is sufficient: https://translate.google.com/?sl=en&tl=zh-CN&op=websites |
|
If it's in markdown, that won't work. Which is why I wrote the translator. |
|
I guess since markdown files are only used as the source and static HTML files are generated for the website, it works fine. Example translation of KF website in Chinese: https://www-kubeflow-org.translate.goog/?_x_tr_sl=en&_x_tr_tl=zh-CN&_x_tr_hl=en&_x_tr_pto=wapp |
|
You absolutely do not want to just translate the generated HTML, since it will be re-generated on the next build. If the Markdown is not translated, then any changes to the static html will be lost on rebuild. |
Checklist:
Description of your changes:
content/bn/aboutcontent/bn/startedcontent/bn/distributionsIssue:
Fixes: #4092
Labels:
/area website