Katib: Add components guide #2962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM! @andreyvelich It might be better to change the required kustomize version in the following section. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, gaocegege, johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: kubeflow/katib#1668.
This PR: kubeflow/katib#1667 removes components guide from the README, we should add it in the Kubeflow guides.
@tenzen-y I am not sure that we need to mention
kustomizein the installation guides, as we discussed here: kubeflow/katib#1667 (comment).I noticed that Kubeflow Pipelines also uses
kubectl apply -k: https://www.kubeflow.org/docs/components/pipelines/installation/standalone-deployment/#deploying-kubeflow-pipelines.More advance users can always clone the Katib repo and use
kustomizeto modify our manifests before installation, we can explain it in the developer guide.What do you think about it @tenzen-y @gaocegege @johnugeorge ?
cc @RFMVasconcelos
/hold for the review