Skip to content

Conversation

mahdikhashan
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
part of #2520

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: mahdikhashan <[email protected]>
@mahdikhashan mahdikhashan changed the title [feature] move manifest image references to ghcr wip: [feature] move manifest image references to ghcr Mar 17, 2025
@juliusvonkohout
Copy link
Member

/retest

@Electronic-Waste
Copy link
Member

@mahdikhashan Thanks for creating this. Maybe we should first update the build-and-publish CI and then update the image in manifests:)

@mahdikhashan
Copy link
Member Author

@mahdikhashan Thanks for creating this. Maybe we should first update the build-and-publish CI and then update the image in manifests:)

yes, you are right, we have the pr here: #2520

@mahdikhashan mahdikhashan changed the title wip: [feature] move manifest image references to ghcr [feature] move manifest image references to ghcr Mar 18, 2025
Signed-off-by: mahdikhashan <[email protected]>
@saileshd1402
Copy link
Contributor

Should we update the images for the examples yamls as well?

@andreyvelich
Copy link
Member

Yes, @mahdikhashan @saileshd1402 please help us to update all examples and references where we use DockerHub to GHCR.

@mahdikhashan
Copy link
Member Author

yes, i'll do so, i may be slow to respond today and tomorrow. thanks

@andreyvelich
Copy link
Member

@mahdikhashan Did you get a chance to update it since we would like to release Katib tomorrow morning

Signed-off-by: mahdikhashan <[email protected]>
@google-oss-prow google-oss-prow bot added size/L and removed size/S labels Mar 21, 2025
Signed-off-by: mahdikhashan <[email protected]>
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

mahdikhashan and others added 2 commits March 21, 2025 10:02
Signed-off-by: mahdikhashan <[email protected]>
@mahdikhashan
Copy link
Member Author

@mahdikhashan Did you get a chance to update it since we would like to release Katib tomorrow morning

sry for the delay, please take a look, it should be ready now. thanks for your time

@mahdikhashan
Copy link
Member Author

cc: @saileshd1402 please take a look when you have time
@kubeflow/wg-automl-leads

Signed-off-by: mahdikhashan <[email protected]>
Signed-off-by: mahdikhashan <[email protected]>
Signed-off-by: mahdikhashan <[email protected]>
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @mahdikhashan!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit db4b68b into kubeflow:master Mar 24, 2025
69 checks passed
@andreyvelich
Copy link
Member

/cherry-pick release-0.18

@google-oss-robot
Copy link

@andreyvelich: #2529 failed to apply on top of branch "release-0.18":

Applying: move to ghcr
Using index info to reconstruct a base tree...
M	manifests/v1beta1/components/controller/trial-templates.yaml
Falling back to patching base and 3-way merge...
Auto-merging manifests/v1beta1/components/controller/trial-templates.yaml
CONFLICT (content): Merge conflict in manifests/v1beta1/components/controller/trial-templates.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 move to ghcr
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andreyvelich
Copy link
Member

@mahdikhashan @saileshd1402 Please can someone help to cherry-pick this PR to the release-0.18 branch ?

saileshd1402 pushed a commit to saileshd1402/katib that referenced this pull request Mar 24, 2025
* move to ghcr

Signed-off-by: mahdikhashan <[email protected]>

* move images to ghcr

Signed-off-by: mahdikhashan <[email protected]>

* manifests

Signed-off-by: mahdikhashan <[email protected]>

* change registry in all path

Signed-off-by: mahdikhashan <[email protected]>

* update script

Signed-off-by: mahdikhashan <[email protected]>

* fix

Signed-off-by: mahdikhashan <[email protected]>

* fix

Signed-off-by: mahdikhashan <[email protected]>

* slight fix

Signed-off-by: mahdikhashan <[email protected]>

---------

Signed-off-by: mahdikhashan <[email protected]>
Signed-off-by: Mahdi Khashan <[email protected]>
google-oss-prow bot pushed a commit that referenced this pull request Mar 24, 2025
* [feature] move manifest image references to ghcr (#2529)

* move to ghcr

Signed-off-by: mahdikhashan <[email protected]>

* move images to ghcr

Signed-off-by: mahdikhashan <[email protected]>

* manifests

Signed-off-by: mahdikhashan <[email protected]>

* change registry in all path

Signed-off-by: mahdikhashan <[email protected]>

* update script

Signed-off-by: mahdikhashan <[email protected]>

* fix

Signed-off-by: mahdikhashan <[email protected]>

* fix

Signed-off-by: mahdikhashan <[email protected]>

* slight fix

Signed-off-by: mahdikhashan <[email protected]>

---------

Signed-off-by: mahdikhashan <[email protected]>
Signed-off-by: Mahdi Khashan <[email protected]>

* revert changes for ipynb

Signed-off-by: sailesh duddupudi <[email protected]>

---------

Signed-off-by: mahdikhashan <[email protected]>
Signed-off-by: Mahdi Khashan <[email protected]>
Signed-off-by: sailesh duddupudi <[email protected]>
Co-authored-by: Mahdi Khashan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants