Changing image repo from docker.io to ghcr.io

[vikas-saxena02]

Purpose of this PR

As per the kubeflow wide initiative to migrate all images from docker.io to ghcr.io kubeflow/maniifests#3010 , I am am making the change to do the same. the sparkoperator repo specific issue is #2480

Proposed changes:

• change image registry to ghcr.io

Change Category

• Bugfix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that could affect existing functionality)
• Documentation update

Rationale

This change is a part of Kubeflow wide initiative kubeflow/maniifests#3010

Checklist

• I have conducted a self-review of my own code.
• I have updated documentation accordingly.
• I have added tests that prove my changes are effective or that my feature works.
• Existing unit tests pass locally with my changes.

Additional comments
/closes #2480

[vikas-saxena02]

/hold

[vikas-saxena02]

@andreyvelich @juliusvonkohout @mahdikhashan FYI

[juliusvonkohout]

Thank you for the PR. Please also upgrade the manifests (kustomize,helm) and cut a release, that we can then synchronize.

[ChenYi015]

spark-operator/.github/workflows/release.yaml

Lines 154 to 156 in c0403dd

	registry: ${{ env.IMAGE_REGISTRY }}
	username: ${{ secrets.DOCKERHUB_USERNAME }}
	password: ${{ secrets.DOCKERHUB_TOKEN }}

I think username and password also need to be updated:

registry: ${{ env.IMAGE_REGISTRY }} 
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

[vikas-saxena02]

spark-operator/.github/workflows/release.yaml

Lines 154 to 156 in c0403dd

	registry: ${{ env.IMAGE_REGISTRY }}
	username: ${{ secrets.DOCKERHUB_USERNAME }}
	password: ${{ secrets.DOCKERHUB_TOKEN }}

I think username and password also need to be updated:

registry: ${{ env.IMAGE_REGISTRY }} 
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

@ChenYi015 done as per your instructions.. thanks for the help!!

[vikas-saxena02]

rebase to master done successfully

[vikas-saxena02]

/unhold

[ChenYi015]

rebase to master done successfully

@vikas-saxena02 The same changes need to be applied to:

spark-operator/.github/workflows/release.yaml

Lines 216 to 218 in d089a43

	registry: ${{ env.IMAGE_REGISTRY }}
	username: ${{ secrets.DOCKERHUB_USERNAME }}
	password: ${{ secrets.DOCKERHUB_TOKEN }}

[vikas-saxena02]

rebase to master done successfully

@vikas-saxena02 The same changes need to be applied to:

spark-operator/.github/workflows/release.yaml

Lines 216 to 218 in d089a43

	registry: ${{ env.IMAGE_REGISTRY }}
	username: ${{ secrets.DOCKERHUB_USERNAME }}
	password: ${{ secrets.DOCKERHUB_TOKEN }}

Thanks for pointing out... this has been actioned as well

[ChenYi015]

LGTM. Will wait for another approval.

[vikas-saxena02]

@andreyvelich are you able to provide your approval. @ChenYi015 has already provided his.

[vikas-saxena02]

/assign @vara-bonthu @andreyvelich @jacobsalway @ImpSy

[jacobsalway]

/lgtm

Matches https://github.com/docker/login-action?tab=readme-ov-file#github-container-registry and doesn't break any local development

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015, jacobsalway

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ChenYi015,jacobsalway]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vara-bonthu]

/assign @andreyvelich
Are we doing this for all the Kubeflow projects? I am good with the change based on the presented issues.

[mahdikhashan]

/lgtm

Thank you

[andreyvelich]

@vara-bonthu Yes, we migrated all repos to GHCR: kubeflow/manifests#3010

[juliusvonkohout]

Amazing, now with a new release of spark operator we can synchronize.

[arturowczarek]

This image hasn't been released yet, has it?

docker pull ghcr.io/kubeflow/spark-operator/controller:2.1.0 Error response from daemon: manifest unknown

[vikas-saxena02]

@arturowczarek this is becuase I dont think we had a release since the changed was merged