Start waiting for certs to be ready before sending data to the channel #2209
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, the controller checks if the cert-generator is enabled before starting
setupControllers
.katib/cmd/katib-controller/v1beta1/main.go
Lines 136 to 149 in 7f0d922
So, if the cert-generator is disabled, the controller sends data to
certsReady
channel before the controller starts waiting for certs to get ready. By this behavior, in the katib-with-kubeflow, the controller eternally keeps waiting for the certs to get ready.katib/cmd/katib-controller/v1beta1/main.go
Lines 170 to 171 in 7f0d922
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: