Skip to content

Conversation

tenzen-y
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y tenzen-y changed the title Immidiately close the certsReady channel if the cert-generator is disabled Immediately close the certsReady channel if the cert-generator is disabled Aug 15, 2023
@tenzen-y tenzen-y force-pushed the close-ready-channel-cert-generator-false branch from 22cce65 to c0a6877 Compare August 15, 2023 17:06
@tenzen-y
Copy link
Member Author

In favor of #2209.
/close

@tenzen-y tenzen-y marked this pull request as ready for review August 15, 2023 17:38
@tenzen-y
Copy link
Member Author

/close

@tenzen-y
Copy link
Member Author

tenzen-y commented Aug 15, 2023

I'm not sure why the prow doesn't close this PR :(

@tenzen-y tenzen-y closed this Aug 15, 2023
@google-oss-prow
Copy link

@tenzen-y: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow
Copy link

@tenzen-y: Closed this PR.

In response to this:

In favor of #2209.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tenzen-y tenzen-y deleted the close-ready-channel-cert-generator-false branch August 15, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant