✨ Create Insights page #2488

sjd78 · 2025-07-23T13:40:05Z

Resolves: #2445
Resolves: https://issues.redhat.com/browse/MTA-5459

Add an Insights page as a clone of the Issues page to shows analysis insights that have an effort=0. Insights with an effort>0 are visible in the existing Issues page.

Summary by CodeRabbit

New Features
- Introduced a comprehensive Insights section with new navigation, routes, and pages for viewing, filtering, and exploring analysis insights and affected applications.
- Added interactive tables for insights, including support for filtering, sorting, pagination, expandable rows, and detailed views.
- Enabled detailed incident and affected file views, including code snippet viewers and modals for in-depth inspection.
- Added localization support for new Insights-related terms.
Enhancements
- Improved data models and query hooks for more granular and structured insight and incident representations.
- Standardized table column management, filtering options, and URL state persistence for insights-related tables.
Bug Fixes
- Updated and aligned components and types to ensure consistency between issues and insights features.
Refactor
- Reorganized and renamed components, hooks, and types to support the new Insights functionality and improve maintainability.
Chores
- Updated navigation and localization files to reflect new Insights features.
- Removed deprecated exports and files related to legacy issues components.

coderabbitai · 2025-07-23T13:40:15Z

Walkthrough

This change introduces a new "Insights" feature to the application, including new data models, API types, routes, and UI components. The insights functionality parallels the existing issues feature, with dedicated pages, tables, filters, and detail views. Numerous components, hooks, and helpers were added or refactored to support insights, while some "issues" components were removed or updated to reflect the new structure.

Changes

File(s) / Group	Change Summary
`client/public/locales/en/translation.json`	Added "insights" and "insight" translation keys.
`client/src/app/Constants.ts`	Added enum values for insights table keys; reordered existing keys.
`client/src/app/Paths.ts`	Added new route constants for insights pages.
`client/src/app/Routes.tsx`	Added lazy-loaded insights components and routes; updated issues route/component names.
`client/src/app/api/models.ts`	Introduced new data models for insights, incidents, reports, and UI ID wrappers; removed/renamed old issue-related interfaces.
`client/src/app/api/rest/analysis.ts`	Updated API function signatures to use new insights types and models.
`client/src/app/layout/SidebarApp/SidebarApp.tsx`	Added navigation item for insights in the sidebar.
`client/src/app/pages/insights/helpers.ts`	Added helpers for insights filters, URLs, and label parsing.
`client/src/app/pages/insights/insights-page.tsx`	Added main InsightsPage component with tabs, filter confirmation, and dynamic content.
`client/src/app/pages/issues/helpers.ts`	Updated imports/types for insights; removed unused functions.
`client/src/app/pages/issues/issues-table.tsx`	Removed IssuesTable component.
`client/src/app/queries/analysis.ts`	Refactored query hooks to use new models and standardized return types for insights/issues.
`client/src/app/utils/query-utils.ts`	Updated `useWithUiId` typing for more flexible usage.
`client/src/app/components/insights/components.ts`	Added barrel file re-exporting insights components.
`client/src/app/components/insights/components/affected-apps-link.tsx`	Updated types, props, and logic for affected apps link in insights context.
`client/src/app/components/insights/components/insight-description-and-links.tsx`	Added component to render insight descriptions and links.
`client/src/app/components/insights/components/insight-expanded-row-content.tsx`	Added component for expanded row content in insights tables.
`client/src/app/components/insights/helpers.ts`	Added helpers for insights URLs and label parsing.
`client/src/app/components/insights/tables/all-insights-table.tsx`	Added AllInsightsTable component for displaying insights data.
`client/src/app/components/insights/tables/column-insight-title.tsx`	Added component for rendering insight titles in table columns.
`client/src/app/components/insights/tables/single-application-insights-table.tsx`	Added SingleApplicationInsightsTable and hook for selected application ID.
`client/src/app/components/insights/tables/use-dynamic-columns.ts`	Added hook for dynamic table column configuration.
`client/src/app/components/insights/tables/use-insight-filters.ts`	Added hook for generating insights table filters.
`client/src/app/pages/insights/affected-applications-page.tsx`	Added AffectedApplicationsPage component for insights.
`client/src/app/pages/insights/file-incidents-detail-modal/file-all-incidents-table.tsx`	Added FileAllIncidentsTable component for displaying incidents in a file.
`client/src/app/pages/insights/file-incidents-detail-modal/file-incidents-detail-modal.tsx`	Added FileIncidentsDetailModal for detailed file incident viewing.
`client/src/app/pages/insights/file-incidents-detail-modal/incident-code-snip-viewer.tsx`	Added IncidentCodeSnipViewer for code snippet display in incidents.
`client/src/app/pages/insights/insight-affected-files-table.tsx`	Added InsightAffectedFilesTable for listing affected files per insight.
`client/src/app/pages/insights/insight-detail-drawer.tsx`	Added InsightDetailDrawer for insight details in a drawer panel.
`client/src/app/pages/issues/affected-applications-page.tsx`	Renamed and updated AffectedApplications component; updated imports.
`client/src/app/pages/issues/affected-applications/index.ts`	Deleted re-export index file for affected applications.
`client/src/app/pages/issues/file-incidents-detail-modal/file-all-incidents-table.css`	Added CSS for empty table cells.
`client/src/app/pages/issues/file-incidents-detail-modal/file-all-incidents-table.tsx`	Updated to use new types/hooks for incidents.
`client/src/app/pages/issues/file-incidents-detail-modal/file-incidents-detail-modal.tsx`	Updated to use new types/hooks/components for insights.
`client/src/app/pages/issues/file-incidents-detail-modal/incident-code-snip-viewer.css`	Added CSS for incident line error highlighting.
`client/src/app/pages/issues/file-incidents-detail-modal/index.ts`	Added re-export for file incidents detail modal module.
`client/src/app/pages/issues/issue-affected-files-table.tsx`	Updated to use new types and unique ID logic for affected files.
`client/src/app/pages/issues/issue-detail-drawer.tsx`	Updated import path for helper function.
`client/src/app/pages/issues/issue-detail-drawer/index.ts`	Removed re-export of issue detail drawer.
`client/src/app/pages/issues/index.ts`	Deleted index file re-export for Issues component.
`client/src/app/pages/issues/issues-page.tsx`	Replaced IssuesTable with new insights-based tables; added detail drawer logic; updated exports.
`client/src/app/components/BreakingPathDisplay.tsx`	Renamed and exported BreakingPathDisplay component; updated docs and default export.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Sidebar
    participant Router
    participant InsightsPage
    participant InsightsAPI
    participant InsightsTable
    participant InsightDetailDrawer

    User->>Sidebar: Clicks "Insights"
    Sidebar->>Router: Navigates to /insights
    Router->>InsightsPage: Renders InsightsPage
    InsightsPage->>InsightsAPI: Fetch insights data
    InsightsAPI-->>InsightsPage: Returns insights
    InsightsPage->>InsightsTable: Renders table with insights
    User->>InsightsTable: Clicks on insight row
    InsightsTable->>InsightDetailDrawer: Opens detail drawer for insight
    InsightDetailDrawer->>InsightsAPI: Fetches insight details
    InsightsAPI-->>InsightDetailDrawer: Returns insight details
    InsightDetailDrawer-->>User: Displays insight detail

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

✨ Refactor analysis API and update query hooks #2481: Refactors and updates analysis API and query hooks for insights and issues, sharing direct code-level changes in models and queries.
✨ Refactor issues api to insights api #2446: Renames and refactors "issues" API/models to "insights", establishing foundational changes extended by this PR.

Suggested reviewers

rszwajko
ibolton336

Poem

In burrows deep, a rabbit spies
New insights sprout before its eyes!
Tables twinkle, drawers slide,
Filters, routes, and models wide.
With paws a-tap and nose a-twitch,
This code now gleams—a feature-rich switch!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 8

🔭 Outside diff range comments (1)

client/src/app/pages/insights/helpers.ts (1)
1-274: Significant code duplication detected.

This entire file appears to be a near-exact duplicate of client/src/app/pages/issues/helpers.ts with minimal naming changes. While this may be intentional per the PR objectives (creating a "clone" of the Issues page), it creates significant maintenance burden.

Consider extracting the common functionality into shared utilities to reduce duplication:
// shared/page-helpers.ts
export const createPageHelpers = (config: {
  paths: {
    allTab: string;
    singleAppTab: string;
    singleAppSelected: string;
    allAffectedApplications: string;
  };
  persistenceKeyPrefix: {
    main: string;
    affectedApps: string;
  };
  fromParamsKey: string;
  filterGroups: {
    applicationInventory: string;
    main: string;
  };
}) => {
  // Return all the helper functions with the config applied
};

// Then use it in both issues and insights helpers:
export const insightsHelpers = createPageHelpers({
  paths: {
    allTab: Paths.insightsAllTab,
    // ... other paths
  },
  // ... other config
});
This would eliminate ~90% of the code duplication while maintaining the separate APIs.

🧹 Nitpick comments (8)

client/src/app/pages/insights/insight-detail-drawer/file-incidents-detail-modal/incident-code-snip-viewer.css (1)

5-5: Consider removing the !important declaration and using proper CSS specificity.

The !important declaration suggests there might be specificity conflicts. It's better to increase specificity through proper selectors rather than using !important, which makes styles harder to override and maintain.
client/src/app/pages/issues/issue-detail-drawer/file-incidents-detail-modal/file-all-incidents-table.tsx (1)
31-31: Consider using insights-specific persistence key.

The component uses TablePersistenceKeyPrefix.issuesRemainingIncidents but this table is used in both issues and insights contexts. Consider using the appropriate persistence key based on context or creating a shared key.

This could be addressed by either:

Passing the appropriate persistence key as a prop

Using a context-agnostic key name

Determining the context dynamically
- persistenceKeyPrefix: TablePersistenceKeyPrefix.issuesRemainingIncidents,
+ persistenceKeyPrefix: TablePersistenceKeyPrefix.insightsRemainingIncidents, // or make it configurable
client/src/app/pages/insights/affected-applications/affected-applications.tsx (1)
155-157: Move inline styles to CSS or use PatternFly utilities

Consider using PatternFly's utility classes or moving this to a CSS file for better maintainability.

Replace the inline style with a PatternFly utility class:
-          <div
-            style={{
-              backgroundColor: "var(--pf-v5-global--BackgroundColor--100)",
-            }}
-          >
+          <div className="pf-v5-u-background-color-100">
client/src/app/pages/insights/insight-detail-drawer/insight-affected-files-table.tsx (1)

57-61: Address the i18n TODO comment

The TODO comment indicates missing internationalization for "file".

Would you like me to help implement the proper i18n for this filter placeholder text or open an issue to track this task?

client/src/app/pages/insights/insight-detail-drawer/file-incidents-detail-modal/file-all-incidents-table.tsx (1)

85-95: Consider moving pagination to toolbar

Having pagination controls inside the table header is unconventional. Consider moving it to a toolbar above the table for better UX consistency.

client/src/app/pages/insights/insights-table.tsx (1)

173-184: Consider extracting effort filtering logic.

The commented-out effort filtering logic suggests uncertainty about the filtering approach. This indicates a potential area for future enhancement.

Consider creating a separate issue to determine the requirements for effort-based filtering and implement it if needed.
client/src/app/pages/insights/insight-detail-drawer/file-incidents-detail-modal/incident-code-snip-viewer.tsx (1)
63-68: Language detection could be more robust.

The language detection relies on file extension mapping but doesn't handle edge cases well.

Consider adding fallback handling for unknown extensions:
  const extension = incident.file.toLowerCase().split(".").slice(-1)[0];
  const language = Object.keys(LANGUAGES_BY_FILE_EXTENSION).includes(extension)
    ? (LANGUAGES_BY_FILE_EXTENSION[
        extension as keyof typeof LANGUAGES_BY_FILE_EXTENSION
      ] as Language)
-   : undefined;
+   : Language.plaintext; // Fallback to plaintext for unknown extensions
client/src/app/queries/analysis.ts (1)

230-230: Consider improving error handling beyond console logging.

While the onError callbacks are valid in React Query v4, simply logging errors to the console may not provide adequate error handling for production use. Consider implementing proper error reporting or user notifications.

Also applies to: 253-253, 276-276

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b5cb7c7 and 1ef0c69.

📒 Files selected for processing (33)

client/public/locales/en/translation.json (2 hunks)
client/src/app/Constants.ts (1 hunks)
client/src/app/Paths.ts (1 hunks)
client/src/app/Routes.tsx (3 hunks)
client/src/app/api/models.ts (2 hunks)
client/src/app/api/rest/analysis.ts (4 hunks)
client/src/app/layout/SidebarApp/SidebarApp.tsx (1 hunks)
client/src/app/pages/insights/affected-applications/affected-applications.tsx (1 hunks)
client/src/app/pages/insights/affected-applications/index.ts (1 hunks)
client/src/app/pages/insights/affected-apps-link.tsx (1 hunks)
client/src/app/pages/insights/components/insight-description-and-links.tsx (1 hunks)
client/src/app/pages/insights/helpers.ts (1 hunks)
client/src/app/pages/insights/insight-detail-drawer/file-incidents-detail-modal/file-all-incidents-table.css (1 hunks)
client/src/app/pages/insights/insight-detail-drawer/file-incidents-detail-modal/file-all-incidents-table.tsx (1 hunks)
client/src/app/pages/insights/insight-detail-drawer/file-incidents-detail-modal/file-incidents-detail-modal.tsx (1 hunks)
client/src/app/pages/insights/insight-detail-drawer/file-incidents-detail-modal/incident-code-snip-viewer.css (1 hunks)
client/src/app/pages/insights/insight-detail-drawer/file-incidents-detail-modal/incident-code-snip-viewer.tsx (1 hunks)
client/src/app/pages/insights/insight-detail-drawer/file-incidents-detail-modal/index.ts (1 hunks)
client/src/app/pages/insights/insight-detail-drawer/index.ts (1 hunks)
client/src/app/pages/insights/insight-detail-drawer/insight-affected-files-table.tsx (1 hunks)
client/src/app/pages/insights/insight-detail-drawer/insight-detail-drawer.tsx (1 hunks)
client/src/app/pages/insights/insight-detail-drawer/path-display.tsx (1 hunks)
client/src/app/pages/insights/insights-page.tsx (1 hunks)
client/src/app/pages/insights/insights-table.tsx (1 hunks)
client/src/app/pages/issues/affected-apps-link.tsx (1 hunks)
client/src/app/pages/issues/components/issue-description-and-links.tsx (1 hunks)
client/src/app/pages/issues/helpers.ts (5 hunks)
client/src/app/pages/issues/issue-detail-drawer/file-incidents-detail-modal/file-all-incidents-table.tsx (3 hunks)
client/src/app/pages/issues/issue-detail-drawer/file-incidents-detail-modal/file-incidents-detail-modal.tsx (2 hunks)
client/src/app/pages/issues/issue-detail-drawer/issue-affected-files-table.tsx (3 hunks)
client/src/app/pages/issues/issues-table.tsx (5 hunks)
client/src/app/queries/analysis.ts (13 hunks)
client/src/app/utils/query-utils.ts (1 hunks)

🧠 Learnings (16)

📓 Common learnings

Learnt from: sjd78
PR: konveyor/tackle2-ui#2446
File: client/src/app/api/rest/analysis.ts:38-63
Timestamp: 2025-07-08T20:16:53.929Z
Learning: Issue #2445 is tracking the remaining naming inconsistencies from the issues-to-insights refactoring, specifically renaming functions like `getIssue` to `getInsight` and parameters like `issueId` to `insightId` in the analysis API client functions.

client/src/app/Constants.ts (1)

Learnt from: sjd78
PR: #2446
File: client/src/app/api/rest/analysis.ts:38-63
Timestamp: 2025-07-08T20:16:53.929Z
Learning: Issue #2445 is tracking the remaining naming inconsistencies from the issues-to-insights refactoring, specifically renaming functions like getIssue to getInsight and parameters like issueId to insightId in the analysis API client functions.

client/src/app/pages/insights/helpers.ts (1)

Learnt from: sjd78
PR: #2446
File: client/src/app/api/rest/analysis.ts:38-63
Timestamp: 2025-07-08T20:16:53.929Z
Learning: Issue #2445 is tracking the remaining naming inconsistencies from the issues-to-insights refactoring, specifically renaming functions like getIssue to getInsight and parameters like issueId to insightId in the analysis API client functions.

client/src/app/pages/issues/components/issue-description-and-links.tsx (1)

Learnt from: sjd78
PR: #2446
File: client/src/app/api/rest/analysis.ts:38-63
Timestamp: 2025-07-08T20:16:53.929Z
Learning: Issue #2445 is tracking the remaining naming inconsistencies from the issues-to-insights refactoring, specifically renaming functions like getIssue to getInsight and parameters like issueId to insightId in the analysis API client functions.

client/src/app/pages/issues/issue-detail-drawer/file-incidents-detail-modal/file-all-incidents-table.tsx (1)

Learnt from: sjd78
PR: #2446
File: client/src/app/api/rest/analysis.ts:38-63
Timestamp: 2025-07-08T20:16:53.929Z
Learning: Issue #2445 is tracking the remaining naming inconsistencies from the issues-to-insights refactoring, specifically renaming functions like getIssue to getInsight and parameters like issueId to insightId in the analysis API client functions.

client/src/app/pages/issues/issue-detail-drawer/file-incidents-detail-modal/file-incidents-detail-modal.tsx (1)

Learnt from: sjd78
PR: #2446
File: client/src/app/api/rest/analysis.ts:38-63
Timestamp: 2025-07-08T20:16:53.929Z
Learning: Issue #2445 is tracking the remaining naming inconsistencies from the issues-to-insights refactoring, specifically renaming functions like getIssue to getInsight and parameters like issueId to insightId in the analysis API client functions.

client/src/app/pages/issues/issue-detail-drawer/issue-affected-files-table.tsx (1)

Learnt from: sjd78
PR: #2446
File: client/src/app/api/rest/analysis.ts:38-63
Timestamp: 2025-07-08T20:16:53.929Z
Learning: Issue #2445 is tracking the remaining naming inconsistencies from the issues-to-insights refactoring, specifically renaming functions like getIssue to getInsight and parameters like issueId to insightId in the analysis API client functions.

client/src/app/Paths.ts (1)

Learnt from: sjd78
PR: #2446
File: client/src/app/api/rest/analysis.ts:38-63
Timestamp: 2025-07-08T20:16:53.929Z
Learning: Issue #2445 is tracking the remaining naming inconsistencies from the issues-to-insights refactoring, specifically renaming functions like getIssue to getInsight and parameters like issueId to insightId in the analysis API client functions.

client/src/app/pages/issues/issues-table.tsx (1)

Learnt from: sjd78
PR: #2446
File: client/src/app/api/rest/analysis.ts:38-63
Timestamp: 2025-07-08T20:16:53.929Z
Learning: Issue #2445 is tracking the remaining naming inconsistencies from the issues-to-insights refactoring, specifically renaming functions like getIssue to getInsight and parameters like issueId to insightId in the analysis API client functions.

client/src/app/utils/query-utils.ts (1)

Learnt from: sjd78
PR: #2432
File: client/src/app/components/schema-defined-fields/utils.tsx:42-47
Timestamp: 2025-07-17T23:29:20.652Z
Learning: In the tackle2-ui codebase, when using yup.lazy for optional object validation, the correct TypeScript typing is ReturnType<typeof yup.lazy<yup.AnySchema>> instead of passing the generic type parameter directly to yup.lazy, due to the specific version of yup being used.

client/public/locales/en/translation.json (1)

Learnt from: sjd78
PR: #2446
File: client/src/app/api/rest/analysis.ts:38-63
Timestamp: 2025-07-08T20:16:53.929Z
Learning: Issue #2445 is tracking the remaining naming inconsistencies from the issues-to-insights refactoring, specifically renaming functions like getIssue to getInsight and parameters like issueId to insightId in the analysis API client functions.

client/src/app/pages/issues/helpers.ts (1)

Learnt from: sjd78
PR: #2446
File: client/src/app/api/rest/analysis.ts:38-63
Timestamp: 2025-07-08T20:16:53.929Z
Learning: Issue #2445 is tracking the remaining naming inconsistencies from the issues-to-insights refactoring, specifically renaming functions like getIssue to getInsight and parameters like issueId to insightId in the analysis API client functions.

client/src/app/api/rest/analysis.ts (1)

Learnt from: sjd78
PR: #2446
File: client/src/app/api/rest/analysis.ts:38-63
Timestamp: 2025-07-08T20:16:53.929Z
Learning: Issue #2445 is tracking the remaining naming inconsistencies from the issues-to-insights refactoring, specifically renaming functions like getIssue to getInsight and parameters like issueId to insightId in the analysis API client functions.

client/src/app/Routes.tsx (1)

Learnt from: sjd78
PR: #2446
File: client/src/app/api/rest/analysis.ts:38-63
Timestamp: 2025-07-08T20:16:53.929Z
Learning: Issue #2445 is tracking the remaining naming inconsistencies from the issues-to-insights refactoring, specifically renaming functions like getIssue to getInsight and parameters like issueId to insightId in the analysis API client functions.

client/src/app/api/models.ts (1)

Learnt from: sjd78
PR: #2446
File: client/src/app/api/rest/analysis.ts:38-63
Timestamp: 2025-07-08T20:16:53.929Z
Learning: Issue #2445 is tracking the remaining naming inconsistencies from the issues-to-insights refactoring, specifically renaming functions like getIssue to getInsight and parameters like issueId to insightId in the analysis API client functions.

client/src/app/queries/analysis.ts (2)

Learnt from: sjd78
PR: #2446
File: client/src/app/api/rest/analysis.ts:38-63
Timestamp: 2025-07-08T20:16:53.929Z
Learning: Issue #2445 is tracking the remaining naming inconsistencies from the issues-to-insights refactoring, specifically renaming functions like getIssue to getInsight and parameters like issueId to insightId in the analysis API client functions.

Learnt from: sjd78
PR: #2467
File: client/src/app/queries/generators.ts:20-20
Timestamp: 2025-07-21T06:01:43.078Z
Learning: The tackle2-ui codebase uses React Query v4 (@tanstack/react-query v4.22.0), where the onError callback in query configurations is still valid and supported. The deprecation of onError callbacks only applies to React Query v5, so suggestions about removing them are premature until the codebase is upgraded.

🧬 Code Graph Analysis (10)

client/src/app/layout/SidebarApp/SidebarApp.tsx (1)

client/src/app/Paths.ts (1)

DevPaths (1-55)

client/src/app/pages/insights/affected-apps-link.tsx (2)

client/src/app/api/models.ts (1)

UiAnalysisReportInsight (662-662)

client/src/app/pages/insights/helpers.ts (2)

InsightsFilterValuesToCarry (37-37)

getAffectedAppsUrl (146-174)

client/src/app/pages/issues/components/issue-description-and-links.tsx (1)

client/src/app/api/models.ts (1)

AnalysisInsightLink (640-643)

client/src/app/pages/issues/affected-apps-link.tsx (1)

client/src/app/api/models.ts (1)

UiAnalysisReportInsight (662-662)

client/src/app/pages/issues/issue-detail-drawer/file-incidents-detail-modal/file-all-incidents-table.tsx (2)

client/src/app/api/models.ts (1)

AnalysisReportFile (707-713)

client/src/app/queries/analysis.ts (1)

useFetchIncidentsForInsight (241-262)

client/src/app/pages/issues/issue-detail-drawer/file-incidents-detail-modal/file-incidents-detail-modal.tsx (2)

client/src/app/api/models.ts (2)

AnalysisInsight (614-628)

AnalysisReportFile (707-713)

client/src/app/queries/analysis.ts (1)

useFetchIncidentsForInsight (241-262)

client/src/app/pages/issues/issue-detail-drawer/issue-affected-files-table.tsx (1)

client/src/app/api/models.ts (2)

AnalysisInsight (614-628)

AnalysisReportFile (707-713)

client/src/app/utils/query-utils.ts (2)

client/src/app/api/models.ts (1)

WithUiId (17-17)

client/src/app/Constants.ts (1)

UI_UNIQUE_ID (27-27)

client/src/app/pages/issues/helpers.ts (2)

client/src/app/queries/tags.ts (1)

useFetchTagsWithTagItems (65-110)

client/src/app/api/models.ts (3)

UiAnalysisReportInsight (662-662)

UiAnalysisReportApplicationInsight (680-681)

AnalysisInsight (614-628)

client/src/app/api/rest/analysis.ts (2)

client/src/app/api/rest.ts (3)

hub (55-65)

template (54-54)

getHubPaginatedResult (130-142)

client/src/app/api/models.ts (6)

AnalysisInsight (614-628)

AnalysisReportFile (707-713)

HubRequestParams (31-41)

AnalysisReportInsight (648-660)

AnalysisReportApplicationInsight (665-678)

AnalysisReportInsightApplication (687-704)

🧰 Additional context used

🧠 Learnings (16)

📓 Common learnings

Learnt from: sjd78
PR: konveyor/tackle2-ui#2446
File: client/src/app/api/rest/analysis.ts:38-63
Timestamp: 2025-07-08T20:16:53.929Z
Learning: Issue #2445 is tracking the remaining naming inconsistencies from the issues-to-insights refactoring, specifically renaming functions like `getIssue` to `getInsight` and parameters like `issueId` to `insightId` in the analysis API client functions.