Additional issue to insight switching and verification

Signed-off-by: Scott J Dickerson <[email protected]>

Author: sjd78

client/public/locales/en/translation.json

@@ -406,6 +406,7 @@
     "jiraConfig": "Jira configuration",
     "issue": "Issue",
     "issues": "Issues",
+    "insights": "Insights",
     "jobFunction": "Job function",
     "jobFunctionDeleted": "Job function deleted",
     "jobFunctions": "Job functions",

client/src/app/Constants.ts

@@ -245,11 +245,15 @@ export enum LocalStorageKey {
 
 // URL param prefixes: should be short, must be unique for each table that uses one
 export enum TablePersistenceKeyPrefix {
-  issues = "i",
   dependencies = "d",
+  issues = "i",
   issuesAffectedApps = "ia",
   issuesAffectedFiles = "if",
   issuesRemainingIncidents = "ii",
+  insights = "in",
+  insightsAffectedApps = "ina",
+  insightsAffectedFiles = "inf",
+  insightsRemainingIncidents = "ini",
   dependencyApplications = "da",
   archetypes = "ar",
   tasks = "t",

client/src/app/pages/insights/affected-applications/affected-applications.tsx

@@ -54,7 +54,7 @@ export const AffectedApplications: React.FC = () => {
   const tableControlState = useTableControlState({
     tableName: "affected-applications-table",
     persistTo: "urlParams",
-    persistenceKeyPrefix: TablePersistenceKeyPrefix.issuesAffectedApps,
+    persistenceKeyPrefix: TablePersistenceKeyPrefix.insightsAffectedApps,
     columnNames: {
       name: "Name",
       description: "Description",

client/src/app/pages/insights/helpers.ts

@@ -140,7 +140,7 @@ export const useSharedAffectedApplicationFilterCategories = <
   ];
 };
 
-const FROM_ISSUES_PARAMS_KEY = "~fromIssuesParams"; // ~ prefix sorts it at the end of the URL for readability
+const FROM_INSIGHTS_PARAMS_KEY = "~fromInsightsParams"; // ~ prefix sorts it at the end of the URL for readability
 
 // URL for Affected Apps page that includes carried filters and a snapshot of original URL params from the Insights page
 export const getAffectedAppsUrl = ({
@@ -158,16 +158,16 @@ export const getAffectedAppsUrl = ({
   filterKeysToCarry.forEach((key) => {
     if (fromFilterValues[key]) toFilterValues[key] = fromFilterValues[key];
   });
-  const baseUrl = Paths.issuesAllAffectedApplications
+  const baseUrl = Paths.insightsAllAffectedApplications
     .replace("/:ruleset/", `/${encodeURIComponent(ruleReport.ruleset)}/`)
     .replace("/:rule/", `/${encodeURIComponent(ruleReport.rule)}/`);
   const prefix = (key: string) =>
-    `${TablePersistenceKeyPrefix.issuesAffectedApps}:${key}`;
+    `${TablePersistenceKeyPrefix.insightsAffectedApps}:${key}`;
 
   return `${baseUrl}?${trimAndStringifyUrlParams({
     newPrefixedSerializedParams: {
       [prefix("filters")]: serializeFilterUrlParams(toFilterValues).filters,
-      [FROM_ISSUES_PARAMS_KEY]: fromInsightsParams,
+      [FROM_INSIGHTS_PARAMS_KEY]: fromInsightsParams,
       insightTitle: getInsightTitle(ruleReport),
     },
   })}`;
@@ -183,13 +183,15 @@ export const getBackToAllInsightsUrl = ({
 }) => {
   // Pull the fromInsightsParams param out of the current location's URLSearchParams
   const fromInsightsParams =
-    new URLSearchParams(fromLocation.search).get(FROM_ISSUES_PARAMS_KEY) || "";
+    new URLSearchParams(fromLocation.search).get(FROM_INSIGHTS_PARAMS_KEY) ||
+    "";
   // Pull the params themselves out of fromInsightsParams
   const prefixedParamsToRestore = Object.fromEntries(
     new URLSearchParams(fromInsightsParams)
   );
   // Pull the filters param out of that
-  const prefix = (key: string) => `${TablePersistenceKeyPrefix.issues}:${key}`;
+  const prefix = (key: string) =>
+    `${TablePersistenceKeyPrefix.insights}:${key}`;
   const filterValuesToRestore = deserializeFilterUrlParams({
     filters: prefixedParamsToRestore[prefix("filters")],
   });
@@ -199,7 +201,7 @@ export const getBackToAllInsightsUrl = ({
     filterValuesToRestore[key] = fromFilterValues[key] || null;
   });
   // Put it all back together
-  return `${Paths.issuesAllTab}?${trimAndStringifyUrlParams({
+  return `${Paths.insightsAllTab}?${trimAndStringifyUrlParams({
     newPrefixedSerializedParams: {
       ...prefixedParamsToRestore,
       [prefix("filters")]: serializeFilterUrlParams(filterValuesToRestore)
@@ -229,10 +231,10 @@ export const getInsightsSingleAppSelectedLocation = (
   const existingFiltersParam =
     fromLocation &&
     new URLSearchParams(fromLocation.search).get(
-      `${TablePersistenceKeyPrefix.issues}:filters`
+      `${TablePersistenceKeyPrefix.insights}:filters`
     );
   return {
-    pathname: Paths.issuesSingleAppSelected.replace(
+    pathname: Paths.insightsSingleAppSelected.replace(
       ":applicationId",
       String(applicationId)
     ),

client/src/app/pages/insights/insight-detail-drawer/file-incidents-detail-modal/file-all-incidents-table.tsx

@@ -28,7 +28,7 @@ export const FileAllIncidentsTable: React.FC<
   const tableControlState = useTableControlState({
     tableName: "file-all-incidents-table",
     persistTo: "urlParams",
-    persistenceKeyPrefix: TablePersistenceKeyPrefix.issuesRemainingIncidents,
+    persistenceKeyPrefix: TablePersistenceKeyPrefix.insightsRemainingIncidents,
     columnNames: {
       line: "Line #",
       message: "Message",

client/src/app/pages/insights/insight-detail-drawer/insight-affected-files-table.tsx

@@ -38,7 +38,7 @@ export const InsightAffectedFilesTable: React.FC<
   const tableControlState = useTableControlState({
     tableName: "affected-files-table",
     persistTo: "urlParams",
-    persistenceKeyPrefix: TablePersistenceKeyPrefix.issuesAffectedFiles,
+    persistenceKeyPrefix: TablePersistenceKeyPrefix.insightsAffectedFiles,
     columnNames: {
       file: "File",
       incidents: "Incidents",

client/src/app/pages/insights/insights-page.tsx

@@ -25,23 +25,23 @@ export enum InsightFilterGroups {
 }
 
 export type InsightsTabPath =
-  | typeof Paths.issuesAllTab
-  | typeof Paths.issuesSingleAppTab;
+  | typeof Paths.insightsAllTab
+  | typeof Paths.insightsSingleAppTab;
 
 export const InsightsPage: React.FC = () => {
   const { t } = useTranslation();
   const location = useLocation();
   const history = useHistory();
-  const singleAppTabMatch = useRouteMatch(Paths.issuesSingleAppTab);
-  const singleAppSelectedMatch = useRouteMatch(Paths.issuesSingleAppSelected);
+  const singleAppTabMatch = useRouteMatch(Paths.insightsSingleAppTab);
+  const singleAppSelectedMatch = useRouteMatch(Paths.insightsSingleAppSelected);
 
   const activeTabPath =
     singleAppTabMatch || singleAppSelectedMatch
-      ? Paths.issuesSingleAppTab
-      : Paths.issuesAllTab;
+      ? Paths.insightsSingleAppTab
+      : Paths.insightsAllTab;
 
   React.useEffect(() => {
-    if (!activeTabPath) history.push(Paths.issuesAllTab);
+    if (!activeTabPath) history.push(Paths.insightsAllTab);
   }, [activeTabPath, history]);
 
   const [navConfirmPath, setNavConfirmPath] =
@@ -61,7 +61,7 @@ export const InsightsPage: React.FC = () => {
           activeKey={activeTabPath}
           onSelect={(_event, tabPath) => {
             const pageHasFilters = new URLSearchParams(location.search).has(
-              `${TablePersistenceKeyPrefix.issues}:filters`
+              `${TablePersistenceKeyPrefix.insights}:filters`
             );
             if (pageHasFilters) {
               setNavConfirmPath(tabPath as InsightsTabPath);
@@ -71,32 +71,32 @@ export const InsightsPage: React.FC = () => {
           }}
         >
           <Tab
-            eventKey={Paths.issuesAllTab}
+            eventKey={Paths.insightsAllTab}
             title={<TabTitleText>All insights</TabTitleText>}
           />
           <Tab
-            eventKey={Paths.issuesSingleAppTab}
+            eventKey={Paths.insightsSingleAppTab}
             title={<TabTitleText>Single application</TabTitleText>}
           />
         </Tabs>
       </PageSection>
       <PageSection>
-        {activeTabPath === Paths.issuesAllTab ? (
+        {activeTabPath === Paths.insightsAllTab ? (
           <InsightsTable mode="allInsights" />
-        ) : activeTabPath === Paths.issuesSingleAppTab ? (
+        ) : activeTabPath === Paths.insightsSingleAppTab ? (
           <InsightsTable mode="singleApp" />
         ) : null}
       </PageSection>
       <ConfirmDialog
         isOpen={!!navConfirmPath}
         title={`Navigating to ${
-          navConfirmPath === Paths.issuesSingleAppTab
+          navConfirmPath === Paths.insightsSingleAppTab
             ? "single application"
             : "all insights"
         }`}
         titleIconVariant="info"
         message={`When navigating to the ${
-          navConfirmPath === Paths.issuesSingleAppTab
+          navConfirmPath === Paths.insightsSingleAppTab
             ? "single application"
             : "all insights"
         } tab, all filtering settings will be reset.`}

client/src/app/pages/insights/insights-table.tsx

@@ -86,7 +86,7 @@ export const InsightsTable: React.FC<IInsightsTableProps> = ({ mode }) => {
 
   const singleAppSelectedMatch = useRouteMatch<{
     applicationId: string;
-  }>(Paths.issuesSingleAppSelected);
+  }>(Paths.insightsSingleAppSelected);
   const selectedAppId = singleAppSelectedMatch
     ? Number(singleAppSelectedMatch.params.applicationId)
     : null;
@@ -102,7 +102,7 @@ export const InsightsTable: React.FC<IInsightsTableProps> = ({ mode }) => {
   const tableControlState = useTableControlState({
     tableName: "insights-table",
     persistTo: "urlParams",
-    persistenceKeyPrefix: TablePersistenceKeyPrefix.issues,
+    persistenceKeyPrefix: TablePersistenceKeyPrefix.insights,
     columnNames: {
       description: "Insight",
       category: "Category",