Skip to content

Check build-system before installing #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2022
Merged

Check build-system before installing #322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion jupyter_releaser/lib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
from subprocess import CalledProcessError

import requests
import toml
from ghapi.core import GhApi
from packaging.version import parse as parse_version
from pkginfo import SDist, Wheel
Expand Down Expand Up @@ -599,7 +600,11 @@ def prep_git(ref, branch, repo, auth, username, url):
# Install the package
# install python package in editable mode with dev and test deps
if util.PYPROJECT.exists():
util.run('pip install -q -e ".[dev,test]"')
# check the package can be installed first
text = util.PYPROJECT.read_text(encoding="utf-8")
data = toml.loads(text)
if data.get("build-system"):
util.run('pip install -q -e ".[dev,test]"')

# prefer yarn if yarn lock exists
elif util.YARN_LOCK.exists():
Expand Down