Skip to content

Check build-system before installing #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2022
Merged

Check build-system before installing #322

merged 1 commit into from
May 19, 2022

Conversation

@jtpio
Copy link
Member

@jtpio jtpio commented May 19, 2022

Fixes #321

@jtpio jtpio added the bug Something isn't working label May 19, 2022
blink1073
blink1073 approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073
Copy link
Contributor

blink1073 commented May 19, 2022

I'll cut a release with this and #323

@blink1073 blink1073 enabled auto-merge (squash) May 19, 2022 15:22
@jtpio
Copy link
Member Author

jtpio commented May 19, 2022

I'll cut a release with this and #323

That would be great, thanks!

@blink1073 blink1073 merged commit 0ece2dd into jupyter-server:main May 19, 2022
@jtpio jtpio deleted the install-py branch May 19, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@blink1073 blink1073 blink1073 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ability to skip the installation of the package in prep-git

2 participants

@jtpio @blink1073