Skip to content

Use setup.py --version by default #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2022
Merged

Use setup.py --version by default #284

merged 2 commits into from
Apr 4, 2022

Conversation

@blink1073
Copy link
Contributor

@blink1073 blink1073 commented Apr 4, 2022 •
edited
Loading

@blink1073 blink1073 added the bug Something isn't working label Apr 4, 2022
@blink1073 blink1073 mentioned this pull request Apr 4, 2022
Closed
jtpio
jtpio approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jtpio
Copy link
Member

jtpio commented Apr 4, 2022

Wondering whether this could even be placed in a try catch block.

In case the python setup.py --version invocation fails, it would try the other files and logic to get the version.

@blink1073
Copy link
Contributor Author

blink1073 commented Apr 4, 2022

Wondering whether this could even be placed in a try catch block.

Done!

@blink1073 blink1073 merged commit e60175a into jupyter-server:main Apr 4, 2022
@blink1073 blink1073 deleted the use-setuppy-version branch April 4, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtpio jtpio jtpio approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blink1073 @jtpio