Skip to content

Use setup.py --version by default #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2022
Merged

Use setup.py --version by default #284

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3b3b1c
use setup.py --version by default
blink1073 Apr 4, 2022
035f9f3
add-try-catch-block
blink1073 Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions jupyter_releaser/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,13 @@ def get_repo():

def get_version():
"""Get the current package version"""
if SETUP_PY.exists():
warnings.warn("Using deprecated setup.py invocation")
try:
return run("python setup.py --version").split("\n")[-1]
except CalledProcessError as e:
print(e)

if PYPROJECT.exists():
text = PYPROJECT.read_text(encoding="utf-8")
data = toml.loads(text)
Expand All @@ -153,10 +160,6 @@ def get_version():
if PACKAGE_JSON.exists():
return json.loads(PACKAGE_JSON.read_text(encoding="utf-8")).get("version", "")

if SETUP_PY.exists():
warnings.warn("Using deprecated setup.py invocation")
return run("python setup.py --version").split("\n")[-1]

raise ValueError("No version identifier could be found!")


Expand Down