Add test for `RelativeCountTrendChartTest` #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

uhafner merged 5 commits into jenkinsci:master from NikolasFunction:test/RelativeCountTrendChartTest

Nov 3, 2021

Contributor

NikolasFunction commented Oct 28, 2021 •

edited

Loading

Added Test for class RelativeCountTrendChart.java
JENKINS-66866

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Ensure that the pull request title represents the desired changelog entry
Please describe what you did
Link to relevant issues in GitHub or Jira
Link to relevant pull requests, esp. upstream and downstream changes
Ensure you have provided tests - that demonstrates feature works or fixes the issue


          Added RelativeCountTrendChartTest

666f4c9

github-actions bot assigned uhafner

NikolasFunction added 2 commits

October 28, 2021 18:51


          Fixed checkstyle

dc1ef87


          Removed keyword 'public' for test class

ee44a78

uhafner changed the title ~~Added RelativeCountTrendChartTest~~ Add test for RelativeCountTrendChartTest

uhafner added the tests label

codecov bot commented Nov 2, 2021 •

edited

Loading

Codecov Report

Merging #355 (404805e) into master (87dca51) will increase coverage by 4.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #355      +/-   ##
============================================
+ Coverage     54.07%   58.18%   +4.11%     
- Complexity      263      280      +17     
============================================
  Files            42       42              
  Lines          1093     1093              
  Branches         92       92              
============================================
+ Hits            591      636      +45     
+ Misses          465      420      -45     
  Partials         37       37

Impacted Files	Coverage Δ
...ics/miner/RelativeCountForensicsSeriesBuilder.java	`50.00% <0.00%> (+50.00%)`	⬆️
.../plugins/forensics/miner/CodeMetricTrendChart.java	`100.00% <0.00%> (+100.00%)`	⬆️
...ugins/forensics/miner/CodeMetricSeriesBuilder.java	`100.00% <0.00%> (+100.00%)`	⬆️
...ugins/forensics/miner/RelativeCountTrendChart.java	`100.00% <0.00%> (+100.00%)`	⬆️
...er/RelativeCountCommitStatisticsSeriesBuilder.java	`100.00% <0.00%> (+100.00%)`	⬆️
...AddedVersusDeletedLinesForensicsSeriesBuilder.java	`100.00% <0.00%> (+100.00%)`	⬆️
...rsusDeletedLinesCommitStatisticsSeriesBuilder.java	`100.00% <0.00%> (+100.00%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87dca51...404805e. Read the comment docs.

uhafner requested changes

View reviewed changes

src/test/java/io/jenkins/plugins/forensics/miner/RelativeCountTrendChartTest.java Outdated

+               * Tests RelativeCountTrendChart.
+               *
+               * @author Nikolas Paripovic
+               *

Member

uhafner Nov 2, 2021

Suggested change

*

src/test/java/io/jenkins/plugins/forensics/miner/RelativeCountTrendChartTest.java

+               *
+               */
+              class RelativeCountTrendChartTest {

Member

uhafner Nov 2, 2021

Use new lines only to structure code

Suggested change

src/test/java/io/jenkins/plugins/forensics/miner/RelativeCountTrendChartTest.java Outdated


		@Test
		void shouldCreate() {

Member

uhafner Nov 2, 2021

Suggested change

src/test/java/io/jenkins/plugins/forensics/miner/RelativeCountTrendChartTest.java Outdated

+               */
+              class RelativeCountTrendChartTest {
+                  private final RelativeCountTrendChart relativeCountTrendChart = new RelativeCountTrendChart();

Member

uhafner Nov 2, 2021

No fields in unit tests, inline that into the method

src/test/java/io/jenkins/plugins/forensics/miner/RelativeCountTrendChartTest.java Outdated

+                  @Test
+                  void shouldCreate() {
+                      Iterable<BuildResult<CommitStatisticsBuildAction>> buildResult = createBuildResults(false);

Member

uhafner Nov 2, 2021

Inline that call to make it readable:

Suggested change

      
                    Iterable<BuildResult<CommitStatisticsBuildAction>> buildResult = createBuildResults(false);
          
                    Iterable<BuildResult<CommitStatisticsBuildAction>> buildResult = new ArrayList<>();

src/test/java/io/jenkins/plugins/forensics/miner/RelativeCountTrendChartTest.java

+                      LinesChartModel linesChartModel = relativeCountTrendChart.create(buildResult, chartModelConfiguration, seriesBuilder);
+                      assertThat(linesChartModel.getSeries()).hasSize(3);
+                      assertThat(linesChartModel.getSeries()).allSatisfy(series -> assertThat(series.getData()).hasSize(4));

Member

uhafner Nov 2, 2021

Optional: if you want to make sure that the chart actually is correct, you can use JSON assertions, see review in #351

NikolasFunction added 2 commits

November 3, 2021 15:24


          Applied suggested changes

73bcd5d


          Code structuring

404805e

Fiesepille commented Nov 3, 2021

Seems to be a bug that commit/build #73bcd5d failed.
Following build #404805e succeeded, allthough the code styling was the only change.

Member

uhafner commented Nov 3, 2021

Seems to be a bug that commit/build #73bcd5d failed.
Following build #404805e succeeded, allthough the code styling was the only change.

I think the download of an artifact from the maven repository was broken but that should be fixed now.

uhafner approved these changes

View reviewed changes

uhafner merged commit ec99858 into jenkinsci:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests