Add unit test for AddedVersusDeletedLinesTrendChart
#351
Conversation
| AddedVersusDeletedLinesTrendChart builder = new AddedVersusDeletedLinesTrendChart(); | ||
|
|
||
| Iterable<BuildResult<CommitStatisticsBuildAction>> buildResultsStub = createBuildResultsStub(); | ||
| ChartModelConfiguration chartModelConfigurationStub = createConfiguration(); |
There was a problem hiding this comment.
Use simple dummy object if possible:
| ChartModelConfiguration chartModelConfigurationStub = createConfiguration(); | |
| ChartModelConfiguration chartModelConfigurationStub = new ChartModelConfiguration(); |
| private Iterable<BuildResult<CommitStatisticsBuildAction>> createBuildResultsStub() { | ||
| return new Iterable<BuildResult<CommitStatisticsBuildAction>>() { | ||
| @Override | ||
| public Iterator<BuildResult<CommitStatisticsBuildAction>> iterator() { | ||
| return null; | ||
| } | ||
| }; | ||
| } |
There was a problem hiding this comment.
It would be easier to replace with something like (see https://github.com/jenkinsci/forensics-api-plugin/blob/master/src/test/java/io/jenkins/plugins/forensics/miner/FilesCountTrendChartTest.java for a reference):
private BuildResult<CommitStatisticsBuildAction> createResult(final int buildNumber, final int added, final int deleted) {
CommitStatisticsBuildAction action = mock(CommitStatisticsBuildAction.class);
CommitStatistics commitStatistics = mock(CommitStatistics.class);
when(commitStatistics.getAddedLines()).thenReturn(added);
when(commitStatistics.getDeletedLines()).thenReturn(deleted);
when(action.getCommitStatistics()).thenReturn(commitStatistics);
Build build = new Build(buildNumber);
return new BuildResult<>(build, action);
}
| void shouldCreate() { | ||
| AddedVersusDeletedLinesTrendChart builder = new AddedVersusDeletedLinesTrendChart(); | ||
|
|
||
| Iterable<BuildResult<CommitStatisticsBuildAction>> buildResultsStub = createBuildResultsStub(); |
There was a problem hiding this comment.
This can be replaced by a simple list:
List<BuildResult<CommitStatisticsBuildAction>> results = new ArrayList<>();
results.add(createResult(2, 20, 10));
results.add(createResult(1, 30, 25));
| SeriesBuilder seriesBuilderStub = createSeriesBuilderStub(); | ||
| LinesDataSet linesDataSet = mock(LinesDataSet.class); | ||
|
|
||
| when(seriesBuilderStub.createDataSet(chartModelConfigurationStub, buildResultsStub)) | ||
| .thenReturn(linesDataSet); |
| assertThat(lineChartModel) | ||
| .satisfies(model -> { | ||
| assertThat(model.getSeries()).size().isEqualTo(2); | ||
| }); |
There was a problem hiding this comment.
| assertThat(lineChartModel) | |
| .satisfies(model -> { | |
| assertThat(model.getSeries()).size().isEqualTo(2); | |
| }); | |
| assertThat(lineChartModel.getSeries()).hasSize(2); |
| .satisfies(model -> { | ||
| assertThat(model.getSeries()).size().isEqualTo(2); | ||
| }); | ||
| } |
There was a problem hiding this comment.
Since this object is converted to JSON it might be easier to validate using JSON assertions as in https://github.com/jenkinsci/forensics-api-plugin/blob/master/src/test/java/io/jenkins/plugins/forensics/miner/FilesCountTrendChartTest.java
| .satisfies(model -> { | ||
| assertThat(model.getSeries()).size().isEqualTo(2); | ||
| }); | ||
| } |
There was a problem hiding this comment.
Since this object is converted to JSON it might be easier to validate using JSON assertions as in https://github.com/jenkinsci/forensics-api-plugin/blob/master/src/test/java/io/jenkins/plugins/forensics/miner/FilesCountTrendChartTest.java
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
============================================
+ Coverage 50.04% 55.71% +5.67%
- Complexity 253 271 +18
============================================
Files 42 42
Lines 1093 1093
Branches 92 92
============================================
+ Hits 547 609 +62
+ Misses 510 447 -63
- Partials 36 37 +1
Continue to review full report at Codecov.
|
uhafner
changed the title
AddedVersusDeletedLinesTrendChart
Uh oh!
There was an error while loading. Please reload this page.