-
Notifications
You must be signed in to change notification settings - Fork 31
Add a unit test for RelativeCountCommitStatisticsSeriesBuilder
#352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
uhafner
merged 5 commits into
jenkinsci:master
from
bleibdirtroy:relativeCountCommitStatisticsSeriesBuilderTest
Nov 3, 2021
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5dd1521
created test file for `RelativeCountCommitStatisticsSeriesBuilder`
bleibdirtroy 830aaa4
added mock
bleibdirtroy 15d2a63
added test for `computeSeries`
bleibdirtroy 5c997af
added constants and stub method
64be625
replaced constants with `RelativeCountForensicsSeriesBuilder` constants
bleibdirtroy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
29 changes: 29 additions & 0 deletions
29
...va/io/jenkins/plugins/forensics/miner/RelativeCountCommitStatisticsSeriesBuilderTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
package io.jenkins.plugins.forensics.miner; | ||
|
||
import java.util.Map; | ||
|
||
import org.junit.jupiter.api.Test; | ||
|
||
import static org.assertj.core.api.Assertions.*; | ||
import static org.mockito.Mockito.*; | ||
|
||
class RelativeCountCommitStatisticsSeriesBuilderTest { | ||
|
||
@Test | ||
void computeSeries() { | ||
RelativeCountCommitStatisticsSeriesBuilder relativeCountCommitStatisticsSeriesBuilder = new RelativeCountCommitStatisticsSeriesBuilder(); | ||
CommitStatisticsBuildAction commitStatisticsBuildActionStub = mock(CommitStatisticsBuildAction.class); | ||
CommitStatistics commitStatistics = mock(CommitStatistics.class); | ||
when(commitStatisticsBuildActionStub.getCommitStatistics()).thenReturn(commitStatistics); | ||
when(commitStatistics.getCommitCount()).thenReturn(7); | ||
when(commitStatistics.getAuthorCount()).thenReturn(11); | ||
when(commitStatistics.getFilesCount()).thenReturn(17); | ||
|
||
Map<String, Integer> result = relativeCountCommitStatisticsSeriesBuilder.computeSeries( | ||
commitStatisticsBuildActionStub); | ||
|
||
assertThat(result.get("commits")).isEqualTo(7); | ||
assertThat(result.get("authors")).isEqualTo(11); | ||
assertThat(result.get("files")).isEqualTo(17); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use the constants of the builder There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A simpler way would be:
|
||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.