Add a unit test for RelativeCountCommitStatisticsSeriesBuilder
#352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #352 +/- ##
============================================
+ Coverage 50.04% 55.44% +5.39%
- Complexity 253 271 +18
============================================
Files 42 42
Lines 1093 1093
Branches 92 92
============================================
+ Hits 547 606 +59
+ Misses 510 450 -60
- Partials 36 37 +1
Continue to review full report at Codecov.
|
uhafner
requested changes
Nov 2, 2021
| import static org.mockito.Mockito.*; | ||
|
|
||
| class RelativeCountCommitStatisticsSeriesBuilderTest { | ||
|
|
Comment on lines
25
to
27
| assertThat(result.get("commits")).isEqualTo(7); | ||
| assertThat(result.get("authors")).isEqualTo(11); | ||
| assertThat(result.get("files")).isEqualTo(17); |
There was a problem hiding this comment.
Use the constants of the builder
There was a problem hiding this comment.
A simpler way would be:
assertThat(result)
.containsEntry(COMMITS, 7)
.containsEntry(AUTHORS, 11);
uhafner
changed the title
RelativeCountCommitStatisticsSeriesBuilderRelativeCountCommitStatisticsSeriesBuilder
uhafner
reviewed
Nov 2, 2021
Comment on lines
11
to
13
| static final String COMMITS = "commits"; | ||
| static final String AUTHORS = "authors"; | ||
| static final String FILES = "files"; |
There was a problem hiding this comment.
uhafner
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.