Fix bug in SSA discovery when LogicStructures are used
#540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
There was a bug in the way that the
Combinational.ssawas discovering/notifying signals of drivers whenLogicStructures were split apart and rejoined. This PR fixes that bug by expanding the search to theparentStructuresignals being searched. It also expands the search to elements ofLogicStructures just in case, even though it appears that wouldn't be a problem.Related Issue(s)
N/A
Testing
Added new tests that reproduce the issue.
Backwards-compatibility
No
Documentation
No