Skip to content

fix(ajax): add query params to fetch method #2543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(ajax): add query params to fetch method #2543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62fdac9
test(ajax): add test for query parameters to fetch
Velorexe Jul 25, 2025
ccc2404
fix(ajax): add params to url for fetch requests
Velorexe Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/ajax/src/Ajax.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,15 @@ export class Ajax {
* @returns {Promise<Response>}
*/
async fetch(info, init, parseErrorResponse = false) {
const request = /** @type {CacheRequest} */ (new Request(info, { ...init }));
const baseUrl = typeof info === 'string' ? info : /** @type {Request} */ (info).url;
const url = `${baseUrl}${init?.params ? `?${new URLSearchParams(init.params)}` : ''}`;

const request = /** @type {CacheRequest} */ (
typeof info === 'string'
? new Request(url, { ...init })
: new Request({ ...info, url }, { ...init })
);

request.cacheOptions = init?.cacheOptions;
request.params = init?.params;

Expand Down
9 changes: 9 additions & 0 deletions packages/ajax/test/Ajax.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,15 @@ describe('Ajax', () => {
expect(response.headers.get('X-Custom-Header')).to.equal('y-custom-value');
});

it('calls fetch with the given query params', async () => {
await ajax.fetch('/foo', { params: { query: 'param', intValue: 1 } });

expect(fetchStub).to.have.been.calledOnce;
const request = fetchStub.getCall(0).args[0];

expect(request.url).to.equal(`${window.location.origin}/foo?query=param&intValue=1`);
});

it('throws on 4xx responses', async () => {
fetchStub.returns(Promise.resolve(new Response('', { status: 400 })));

Expand Down