fix(ajax): add query params to fetch method #2543
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this for
In the
CacheRequestobject in theAjaxfile the propertiesparamsare set, meaning that theinitargument that gets passed to thefetch()method allows for the usage of theparamsproperty. This creates an illusion that thefetch()method automatically adds parameters to the request, resulting in query parameters being passed to the final URL that theRequestis going to.However, both the definition of
RequestandCacheRequestboth miss theparamsproperty, so they won't be used. In thecacheManagerthere is a method that interacts with theparamsproperty of cached requests.If this was intended behavior, then I can rebrand this PR as a
featinstead, as this allows for extra easy usability of thefetchwrapper in the lion package.Is this breaking
No, this only adds functionality, leaving the standard workflow intact.
What does this solve
My issue that has been open for a while: #2363