Skip to content

Conversation

@Velorexe
Copy link

What is this for

In the CacheRequest object in the Ajax file the properties params are set, meaning that the init argument that gets passed to the fetch() method allows for the usage of the params property. This creates an illusion that the fetch() method automatically adds parameters to the request, resulting in query parameters being passed to the final URL that the Request is going to.

However, both the definition of Request and CacheRequest both miss the params property, so they won't be used. In the cacheManager there is a method that interacts with the params property of cached requests.

If this was intended behavior, then I can rebrand this PR as a feat instead, as this allows for extra easy usability of the fetch wrapper in the lion package.

Is this breaking

No, this only adds functionality, leaving the standard workflow intact.

What does this solve

My issue that has been open for a while: #2363

@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2025

⚠️ No Changeset found

Latest commit: ccc2404

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Jul 25, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants