feat: Use Spirc for player logic #1692
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Heavily WIP, only does basic playback so far** The idea is to use librespot `Spirc` instead of handling the player logic within ncspot. This should reduce complexity a bit, but also allows us to integrate with Spotify Connect, which in turn would enable ncspot to be controlled via Spotify Apps.
hrkfdn
force-pushed
the
hf/spirc_player
branch
from
20b3694 to
5eb790f
Compare
Makes `PlayerEvent` enum more extensible as it was previously misused to keep track of the player status.
Keeps ncspot in sync with Librespot volume.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heavily WIP, only does basic playback so far.
Todo
TrackChangedeventsVolumeChangedeventsDescribe your changes
The idea is to use librespot
Spircinstead of handling the player logic within ncspot. This should reduce complexity a bit, but also allows us to integrate with Spotify Connect, which in turn would enable ncspot to be controlled via Spotify Apps.Issue ticket number and link
Checklist before requesting a review
not performance improvements, etc.)