Missing spotify-connect support

[FrostyX]

Ncspot doesn't seem to implement spotify-connect support meaning that it doesn't appear in other players (official app, website) as a device. Consequently, it is not possible to control remote device, that is playing music with my local ncspot.

It shouldn't be that hard to implement because spotifyd knows it and it is also based on the librespot

[evamvid]

seconded! This is already implemented in librespot.

[hrkfdn]

I've looked into this and unfortunately it's not that simple. The librespot interface for Spotify connect is a different than the one we use now for direct playback. It would probably require a rework of the entire Spotify player backend on our side..

[master-hax]

I'm a little confused, does ncspot not use the most up to date verision of librespot?

[hrkfdn]

Yes, it does. But unless I'm missing something, the interface isn't designed this way. librespot's Spotify Connect implementation is contained in an interface called Spirc: https://github.com/librespot-org/librespot/blob/master/connect/src/spirc.rs

Spirc consumes the session and player objects that we need to play songs. If we hand these objects to Spirc, we cannot control the player object anymore except for a limited set of playback control operations (play, pause, stop, etc. - see: https://github.com/librespot-org/librespot/blob/51a634dc33233ca85a92db3e723d19550b548593/connect/src/spirc.rs#L282).

If we wanted to control the queue of the Spirc player, we would have to reimplement our entire playlist system to make use of the web api to control the local Spotify Connect player. This would involve a major rewrite of all the parts involving player control, which is why this feature is a lot more complicated than it seems.

[hrkfdn]

Closing this as it is out of scope and would require massive rewrites/architecture changes due to the way librespot's Spotify Connect (SPIRC) is designed.

[photovoltex]

Closing this as it is out of scope and would require massive rewrites/architecture changes due to the way librespot's Spotify Connect (SPIRC) is designed.

@hrkfdn Does that mean you don't want to add it at all? Or would you add it, if anyone would do the refacotring? So would replacing the current logic ("private/disconnected session") with the spirc ("connected session") be in favor of most people? Or would a mixed solution be the only way to implement it? I would rather advise against the mixed solution because of the maintance overhead.

[hrkfdn]

@photovoltex Thanks for the follow up! No, I'm not opposed to the feature itself. I just didn't have to time/capacity to take care of it. Contributions are very welcome :) I also think using the Spirc session would be the way to go. That way ncspot could also be controlled by other Spotify Connect clients.