fix(listener): Limit retries to a maximum of three. #267
+91
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yusukebe |
|
Hi @usualoma I've tried some edge cases based on your repro. They work well! Looks good, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #266
If the application did not include
Transfer-Encoding: chunked, depending on the timing of enqueue, it would loop indefinitely until the second chunk was read.One way to do this is to treat
text/event-streamas special, as @yusukebe pointed out in this comment, but I would prefer to resolve this without depending on a specificContent-Type.#265 (comment)
Essentially, the problem was simply #265's
i--andcurrentReadPromise = reader.read(), so I think that fixing that should be sufficient without any additional logical changes.Minimal reproducible example
https://github.com/usualoma/hono-se-266