fix(listener): In Node.js v24, some response bodies are not read to the end until the next task queue. #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he end until the next task queue.
yusukebe
reviewed
Jul 30, 2025
usualoma
changed the title
usualoma
changed the title
usualoma
force-pushed
the
fix-wait-next-task-node24
branch
from
16d1029 to
98f2792
Compare
|
Hi @yusukebe. The content is still in the first version. Please review with this. |
|
Looks good to me. I'll merge and release a new version. Thank you!
Agree! |
This was referenced Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #264
I considered making the following additional commit, but since it would change the behavior a bit and I am concerned about the performance impact (and, in fact, the need to deal with more case-sensitive parts), I would like to complete the fix with only the first commit and not add anything in particular.
usualoma/node-server@fix-wait-next-task-node24...usualoma:node-server:fix-wait-next-task-node24-2