-
-
Notifications
You must be signed in to change notification settings - Fork 790
feat(bun/ws): allow to import upgradeWebSocket
and websocket
directly
#4242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bun/ws): allow to import upgradeWebSocket
and websocket
directly
#4242
Conversation
- Add conditional logic to handle external fork PRs - Internal PRs: post comment as before - Fork PRs: show results in logs due to permission restrictions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude <[email protected]>
* fix(utils/color): avoid unhandled scheme errors * test: add esbuild test
* fix(utils/color): avoid resolving pacakages via Bun.build * fix: use try/catch instead of let
* fix(cookie): use `tryDecode` when parsing cookie * add test * typo
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #4242 +/- ##
==========================================
- Coverage 91.44% 91.23% -0.21%
==========================================
Files 170 170
Lines 10881 10884 +3
Branches 3103 3077 -26
==========================================
- Hits 9950 9930 -20
- Misses 930 953 +23
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi @nakasyou Looks good to me! I'll include this change in the next minor release |
Hi @yusukebe. Thank you for reviewing. I don't hurry so releasing with |
I've just realized that WebSocket helper didn't require
createBunWebSocket
to provide functions used to upgrade connections.This PR allows to write code like the code:
Codes using a WebSocket with Bun will become simpler than before.
The author should do the following, if applicable
bun run format:fix && bun run lint:fix
to format the code