Skip to content

Conversation

yusukebe
Copy link
Member

@yusukebe yusukebe commented Jun 20, 2025

Fixes #1906

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

This comment has been minimized.

This comment has been minimized.

Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.27%. Comparing base (3e51a1f) to head (f81054a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4240   +/-   ##
=======================================
  Coverage   91.27%   91.27%           
=======================================
  Files         170      170           
  Lines       10802    10803    +1     
  Branches     3115     3189   +74     
=======================================
+ Hits         9859     9860    +1     
  Misses        942      942           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This comment has been minimized.

This comment has been minimized.

@yusukebe yusukebe marked this pull request as ready for review June 21, 2025 01:16
@yusukebe
Copy link
Member Author

Hi @usualoma

Can you review this?

@usualoma
Copy link
Member

Hi @yusukebe, thank you. LGTM!

Copy link

Bundle size check

main (3e51a1f) #4240 (af77829) +/-
Bundle Size (B) 18,206B 18,206B 0B
Bundle Size (KB) 17.78K 17.78K 0K

Compiler Diagnostics (tsc)

main (3e51a1f) #4240 (af77829) +/-
Files 262 262 0
Lines 116,386 116,387 1
Identifiers 114,401 114,406 5
Symbols 259,899 259,900 1
Types 162,566 162,566 0
Instantiations 3,039,295 3,039,295 0
Memory used 270,613K 271,351K 738K
I/O read 0.02s 0.02s 0s
I/O write 0s 0s 0s
Parse time 0.65s 0.67s 0.02s
Bind time 0.27s 0.29s 0.02s
Check time 3.72s 3.8s 0.08s
Emit time 0s 0s 0s
Total time 4.65s 4.76s 0.11s

Compiler Diagnostics (typescript-go)

main (3e51a1f) #4240 (af77829) +/-
Files 232 232 0
Lines 106,285 106,286 1
Identifiers 106,141 106,146 5
Symbols 371,531 371,532 1
Types 293,004 293,008 4
Instantiations 3,568,491 3,568,491 0
Memory used 229,643K 229,857K 214K
Memory allocs 10,003,529 10,003,495 -34
Parse time 0.07s 0.084s 0.014s
Bind time 0.019s 0.018s -0.001s
Check time 1.367s 1.499s 0.132s
Emit time 0s 0s 0s
Total time 1.468s 1.613s 0.145s

Reported by octocov

Copy link

HTTP Performance Benchmark

Framework Runtime Average Ping Query Body
hono (origin/main) bun 35,646.94 48,571.29 30,929.29 27,440.25
hono (current) bun 36,553.23 50,125.08 31,668.90 27,865.71
Change +2.54% +3.20% +2.39% +1.55%

@yusukebe
Copy link
Member Author

@usualoma Thanks! Merging.

@yusukebe yusukebe merged commit 54cf3fb into main Jun 21, 2025
17 checks passed
@yusukebe yusukebe deleted the fix/cookie-parse-try-decode branch June 21, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate signed cookie throws on malformed URI
2 participants